Move Boost.StaticAssert to Boost.Config #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's not delete the tests from here. They must still pass. |
Member
Author
|
I moved the tests to Boost.Config, do we need to leave the duplicates here? And the CI on this PR will fail anyway because the header is removed and not yet added to Boost.Config's develop. |
Member
|
Yes, I prefer to have the tests remain here. |
This library has been merged into Boost.Config, including sources, documentation, tests and examples. index.html updated to redirect to Boost.Config. README.md and meta/libraries.json were updated to mention that the library was merged into Boost.Config. CMakeLists.txt and build.jam are retained to define Boost.StaticAssert targets, which are now empty and only add the dependency on Boost.Config. This is to avoid breaking downstream libraries that have Boost.StaticAssert as a dependency. These users will need to be updated, and at that point this entire git submodule can be deleted. Tests, examples and CI configs are preserved at the request by Peter Dimov.
Lastique
force-pushed
the
feature/move_static_assert
branch
from
34a00ea to
4cc0d67
Compare
Member
Author
|
Ok, I have restored tests and examples (which are built as part of testing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows this discussion on the Boost ML.
Removed library sources, docs, tests and examples; refer to Boost.Config.
This library has been merged into Boost.Config, including sources, documentation, tests and examples. CI configs are removed as there is nothing left to test. index.html updated to redirect to Boost.Config. README.md and meta/libraries.json were updated to mention that the library was merged into Boost.Config.
CMakeLists.txt and build.jam are retained to define Boost.StaticAssert targets, which are now empty and only add the dependency on Boost.Config. This is to avoid breaking downstream libraries that have Boost.StaticAssert as a dependency. These users will need to be updated, and at that point this entire git submodule can be deleted.
This PR must be merged together with boostorg/config#531.