test/tmt: Use bootc usroverlay for /usr overlay mount
#1882
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were mounting a rw overlay on top of /usr using `mount -t overlay -olowerdir=/usr,workdir=...,upperdir=... overlay /usr` which caused the kernel to throw `overlayfs: maximum fs stacking depth exceeded` possibly because the mountpoint was the same as the lowerdir Also, move the overlay mount BEFORE we mask off `/sysroot/ostree` else bootc throws `error: Read only filesystem` Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates two test files, test-install-outside-container.nu and test-install-unified-flag.nu, to use the bootc usr-overlay command. This replaces the manual creation of an overlay mount on /usr, which was causing kernel errors. The change also correctly reorders the operations, creating the overlay before masking /sysroot/ostree, to fix a Read only filesystem error. These changes make the test setup cleaner, more robust, and align with the intended usage of bootc tooling. The implementation is correct and improves the reliability of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were mounting a rw overlay on top of /usr using
mount -t overlay -olowerdir=/usr,workdir=...,upperdir=... overlay /usrwhich caused the kernel to throwoverlayfs: maximum fs stacking depth exceededpossibly because the mountpoint was the same as the lowerdir
Also, move the overlay mount BEFORE we mask off
/sysroot/ostreeelse bootc throwserror: Read only filesystem