fix #186 #191
Merged
fix #186 #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexodia
requested changes
Dec 17, 2025
Contributor
mrexodia
left a comment
mrexodia
left a comment
There was a problem hiding this comment.
Minor change required for Windows
cmake/cmkr.cmake
Outdated
| set(CMKR_DIRECTORY_PREFIX "$ENV{CMKR_CACHE}") | ||
| string(REPLACE "\\" "/" CMKR_DIRECTORY_PREFIX "${CMKR_DIRECTORY_PREFIX}") | ||
| if(CMKR_DIRECTORY_PREFIX MATCHES "^~") | ||
| string(REGEX REPLACE "^~" "$ENV{HOME}" CMKR_DIRECTORY_PREFIX "${CMKR_DIRECTORY_PREFIX}") |
Contributor
There was a problem hiding this comment.
This only works on unix systems, windows requires $ENV{USERPROFILE}
Contributor
Author
There was a problem hiding this comment.
but tilde is specific to unix systems? And in windows, if a user sets %USERPROFILE% in an environment variable it is automatically expanded
Contributor
There was a problem hiding this comment.
Yes the ~ is unix-specific, but people using git bash might enter something like this and adding support for it isn't difficult.
Contributor
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tilde expansion before attempting a git clone, Fixes #186