Fix promotion of top-level checkbox not removing it properly #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this tries to solve:
Calling promote here previously only removed the dash, not the brackets.
Explanation:
parse_bulletmatches and returns both the bullet (withtext_after_bulletbeing[ ] abc) and the checkbox (withtext_after_bulletbeingabc).When promoting,
change_line_bullet_levelwas considering the first item returned byparse_bulletand thus keeping the text after the bullet, including the[ ].I changed it to use the last returned item so that only the text after the checkbox is kept.