Skip to content

fix issue with profile update #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
callofcode07 merged 2 commits into from
Nov 21, 2025
Merged

fix issue with profile update #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb0ff6f
fix issue with profile update
Harish-Naruto Nov 21, 2025
a2c06a4
Update updateMember test
Sherin-2711 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/controllers/member.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const updateAMember =
(supabase: SupabaseClient) => async (req: Request, res: Response) => {

const { memberId } = req.params;

if(!memberId) throw new ApiError("No memberId provided", 400);

const parsedBody = JSON.parse(req.body.memberData);
Expand All @@ -84,7 +84,7 @@ export const updateAMember =
const oldData = await memberService.getDetails(memberId);
const oldImage = oldData?.profilePhoto;

if(oldImage) await uploadImage(supabase, req.file, "members", oldImage);
if(oldImage) imageUrl = await uploadImage(supabase, req.file, "members", oldImage);
else imageUrl = await uploadImage(supabase, req.file, "members");
}
if (imageUrl) parsedBody.profilePhoto = imageUrl;
Expand Down Expand Up @@ -155,4 +155,4 @@ export const getUserInterviews = async (req: Request, res: Response) => {

const interviews = await memberService.getInterviews(memberId);
res.status(200).json({ success: true, interviews });
};
};
2 changes: 2 additions & 0 deletions tests/Member.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,10 @@ describe('Member Controller - updateAMember', () => {
);

expect(memberService.updateMember).toHaveBeenCalledWith('abc-123', {
profilePhoto: 'https://new.url/image.png',
});


expect(res.status).toHaveBeenCalledWith(200);
expect(res.json).toHaveBeenCalledWith({
success: true,
Expand Down