Add logger utility and integrate with error handling and request logging #62
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||||||||||||||||||||||||||
| import winston from 'winston'; | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| const logger = winston.createLogger({ | ||||||||||||||||||||||||||||||
| level: "http", | ||||||||||||||||||||||||||||||
| format: winston.format.combine( | ||||||||||||||||||||||||||||||
| winston.format.timestamp(), | ||||||||||||||||||||||||||||||
| winston.format.json() | ||||||||||||||||||||||||||||||
| ), | ||||||||||||||||||||||||||||||
| transports: [ | ||||||||||||||||||||||||||||||
| new winston.transports.Console({ | ||||||||||||||||||||||||||||||
| format: winston.format.combine( | ||||||||||||||||||||||||||||||
| winston.format.colorize(), | ||||||||||||||||||||||||||||||
| winston.format.simple() | ||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| logger.stream = { | ||||||||||||||||||||||||||||||
| write: (message: any) => { | ||||||||||||||||||||||||||||||
| logger.info(message.trim()); | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| } as any; | ||||||||||||||||||||||||||||||
|
Comment on lines
+19
to
+23
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Replace type assertions with proper TypeScript interfaces. The 🔎 Proposed fix+interface LoggerStream {
+ write(message: string): void;
+}
+
-logger.stream = {
- write: (message: any) => {
+logger.stream = {
+ write: (message: string) => {
logger.info(message.trim());
}
-} as any;
+} as LoggerStream;📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| export { logger }; | ||||||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Add type safety and fix edge case in LoggerStream.
The LoggerStream implementation has two issues:
lastIndexOf('\n')returns -1 if no newline exists, causingsubstring(0, -1)to return an empty string🔎 Proposed fix
Note: Using
trim()is simpler and handles all trailing whitespace, matching the pattern already used insrc/utils/logger.tsline 21.📝 Committable suggestion
🤖 Prompt for AI Agents