fix: replace broken validate.sh by validate.js
#285
+328
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BASH script has several issues: 1. Doesn't failed on error, because in bash variable (like `exampled_failed`) updated into a while loop are not updated outside the loop, because a while loop is a subprocess, you can look at https://www.baeldung.com/linux/while-loop-variable-scope 2. find: warning: you have specified the global option -maxdepth after the argument -type, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it. Please specify global options before other arguments. Because 1. is a symptom of the limit of bash for this script, and the tools already require the javascript stack (nodejs/bun/...) I replace the validate.sh by validate.js Signed-off-by: David Bernard <david.bernard.31@gmail.com>
davidB
force-pushed
the
fix-conformance-validation
branch
from
12eae26 to
9920267
Compare
…ext.specversion` Signed-off-by: David Bernard <david.bernard.31@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
validate.shbyvalidate.jsthat failed the CI on invalid json schema or conformance *.jsonBASH script has several issues:
exampled_failed) updated into a while loop are not updated outside the loop, because a while loop is a subprocess, you can look at https://www.baeldung.com/linux/while-loop-variable-scope soexampled_failedare not used to detect invalid conformance vs json schemaBecause 1. is a symptom of the limit of bash for this script, and the tools already require the javascript stack (nodejs/bun/...) I replace the validate.sh by validate.js with the fix (see CI that failed)
FIX #284
Submitter Checklist
As the author of this PR, please check off the items in this checklist: