Seeing what has changed since last clabs allhands #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description
This PR aims to speed up the overall build time by switching cache
action version to v4. The problem with previous version was that post
restore steps were unexpectedly slow. On the new version this does not
seem to be a problem anymore.
### Other changes
None.
### Tested
Ran CI multiple times.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the version of the `actions/cache` used in the GitHub
Actions workflow from `v3` to `v4` for both the node cache and the build
artifacts cache.
### Detailed summary
- Updated `actions/cache` version from `v3` to `v4` for the `Restore
node cache` step.
- Updated `actions/cache` version from `v3` to `v4` for the `Restore
build artifacts cache` step.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description we were missing the fact that base fee or gas price should be multipled by some buffer and that priority fee should be added to these when setting max fee per gas. ### Other changes setup tests with realistic values obtained by making rpc call with cast ### Tested see the tests ### Related issues - Fixes #227 ### Backwards compatibility yes ### Documentation n/a <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing the calculation of `maxFeePerGas` in the `Connection` class, ensuring it includes a buffer based on the `baseFeePerGas`. It also updates tests to reflect the new logic. ### Detailed summary - Updated `maxFeePerGas` calculation to include a buffer. - Introduced `addBufferToBaseFee` function to apply the buffer. - Modified logic to determine `baseFee` based on `feeCurrency`. - Adjusted tests for `setFeeMarketGas` to validate new calculations. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @celo/contractkit@8.3.0 ### Minor Changes - [#348](#348) [`76d09b7`](76d09b7) Thanks [@shazarre](https://github.com/shazarre)! - Adds support for firstKnownEpoch, getFirstBlockAtEpoch, getLastBlockAtEpoch on EpochManager wrapper ### Patch Changes - Updated dependencies \[[`433b70e`](433b70e)]: - @celo/connect@6.0.2 ## @celo/celocli@5.2.1 ### Patch Changes - [#348](#348) [`76d09b7`](76d09b7) Thanks [@shazarre](https://github.com/shazarre)! - Fix network:info command when in L2 - Updated dependencies \[[`433b70e`](433b70e), [`76d09b7`](76d09b7)]: - @celo/connect@6.0.2 - @celo/contractkit@8.3.0 ## @celo/connect@6.0.2 ### Patch Changes - [#350](#350) [`433b70e`](433b70e) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix calculation of maxFeePerGas. Multiple base Fee by constant for buffer <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the versions of the `@celo/connect` and `@celo/contractkit` packages, along with minor bug fixes and improvements in the changelogs for each package. ### Detailed summary - Updated `@celo/connect` from `6.0.1` to `6.0.2` - Updated `@celo/contractkit` from `8.2.0` to `8.3.0` - Updated `@celo/celocli` from `5.2.0` to `5.2.1` - Added changelog entries for versions `6.0.2`, `8.3.0`, and `5.2.1` - Fixed calculation of `maxFeePerGas` in `@celo/connect` - Added support for new methods in `@celo/contractkit` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### Description As described[ in this form post](https://forum.celo.org/t/deprecation-of-celo-wallet-rpc/8452) the @celo/wallet-rpc package is being removed. `personal_` namespace is deprecated in geth. and already not supported in testing environments like anvil. ### Other changes nope ### Tested n/a ### Related issues - Fixes #257 - fixes celo-org/celo-blockchain-planning#431 ### Backwards compatibility nope ### Documentation docs updated <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on the deletion of various files and directories related to the `wallet-rpc` module in the SDK, indicating a significant removal of components from the project. ### Detailed summary - Deleted the entire `docs/sdk/wallet-rpc` directory, including `README.md` and multiple module documentation files. - Removed the `wallet-rpc` directory from `packages/sdk/wallets`, including its `README.md`, configuration files, and source files. - Eliminated test utility files related to `ganache` in `src/test-utils`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
### Description Penultimate step of sunsetting the reserve commands. https://forum.celo.org/t/sunset-of-reserve-commands/8454 ### Other changes n/a ### Tested n/a ### Related issues - Fixes celo-org/celo-blockchain-planning#439 ### Backwards compatibility nope ### Documentation docs for commands removed <!-- start pr-codex --> --- ## PR-Codex overview This PR removes the support for `reserve:*` commands in the CLI as part of the deprecation process outlined in a forum discussion. ### Detailed summary - Deleted the following files: - `packages/cli/src/commands/reserve/status.ts` - `packages/cli/src/commands/reserve/transfergold.ts` - `packages/cli/src/commands/reserve/transfergold.test.ts` - Updated the `changeset/gold-pumas-fry.md` to reflect the major version change for `@celo/celocli` and document the removal of `reserve:*` commands. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
### Description @celo/contractkit has for a long time basically had within it a subpackage under /identity that really didnt have anything to do with contractkit. Removing it will make it easier to build social connect tools as they use the IdentityMetadataMapper contained in here. However this is not social connect tool so it will remain in the developer tooling repo. This is a prereq to remove contractkit as a dependency for social connect. a long term aim. ### Other changes ### Tested uses existing tests ### Related issues - Fixes #15 ### Backwards compatibility nope exports moved to a new package. file structure slightly altered. parameter for IdentityMetadataMapper changes to take an object with specific functions rather than a kit ### Documentation <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the `@celo/metadata-claims` package, extracting identity-related functionality from `@celo/contractkit`. This allows developers to use the `IdentityMetadataWrapper` independently of `ContractKit`, enhancing modularity and usability. ### Detailed summary - Created `@celo/metadata-claims` package. - Moved identity and claims-related functionality from `@celo/contractkit`. - Updated imports in CLI commands and SDK files to use the new package. - Introduced types like `AccountMetadataSignerGetters`. - Removed identity-related exports from `@celo/contractkit`. - Added tests for new functionality in the `metadata-claims` package. > The following files were skipped due to too many changes: `packages/sdk/wallets/wallet-rpc/lib/rpc-signer.js.map`, `packages/sdk/wallets/wallet-rpc/lib/rpc-signer.js`, `packages/sdk/wallets/wallet-rpc/lib/rpc-wallet.test.js.map`, `docs/sdk/metadata-claims/modules/claim.md`, `packages/sdk/wallets/wallet-rpc/lib/rpc-wallet.test.js`, `docs/sdk/metadata-claims/classes/metadata.IdentityMetadataWrapper.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
### Description
these have been either marked deprecated for ages and or are just
completely out of scope for the type of functions we should be
supporting.
### Other changes
nope.
### Tested
seem unused internally
### Related issues
### Backwards compatibility
nope / removing things
### Documentation
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on removing deprecated functions and constants from
various modules in the `sdk` package, specifically related to
`contacts`, `displayFormatting`, `currencies`, and `phoneNumbers`. It
also introduces new claim types and metadata handling in the
`metadata-claims` module.
### Detailed summary
- Removed deprecated functions and constants from:
- `contacts`
- `displayFormatting`
- `currencies`
- `phoneNumbers`
- Introduced new claim types in `metadata-claims`:
- `AccountClaimType`
- `KeybaseClaimType`
- `DomainClaimType`
- `NameClaimType`
- `StorageClaimType`
- Enhanced `IdentityMetadataWrapper` for improved metadata handling.
- Updated documentation to reflect removed exports and new structures.
> The following files were skipped due to too many changes:
`packages/sdk/metadata-claims/lib/metadata.js`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description As proposed in https://forum.celo.org/c/announcements/5 we are removing these identity related commands. Wait to merge till October ### Tested n.a ### Related issues - Fixes celo-org/celo-blockchain-planning#432 ### Backwards compatibility a breaking change ### Documentation hopefully not <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on the removal of the `identity:identifier` and `identity:get-attestations` commands from the CLI, along with updates to the documentation reflecting these changes. ### Detailed summary - Deleted files: - `packages/cli/src/commands/identity/identifier.ts` - `packages/cli/src/commands/identity/get-attestations.ts` - `packages/cli/src/commands/identity/get-attestations.test.ts` - Updated `docs/command-line-interface/identity.md` to remove references to the deleted commands. - Added a note about the deprecation of these commands with a link to the relevant forum discussion. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Fixes master
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the `yarn.lock` file by removing the block for
`@celo/wallet-rpc` and its associated dependencies, while retaining the
entry for `@chainsafe/as-sha256`.
### Detailed summary
- Removed block for
`@celo/wallet-rpc@workspace:packages/sdk/wallets/wallet-rpc` including:
- Version and resolution details
- Dependencies such as `@celo/base`, `@celo/connect`, and others
- Retained entry for `@chainsafe/as-sha256@npm:^0.3.1` with version
0.3.1.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
<!-- start pr-codex -->
## PR-Codex overview
This PR introduces the `@celo/viem-account-ledger` library, facilitating
interactions between Ledger devices and the `viem` framework. It
includes type definitions, configurations, and initial implementations
for ledger account management.
### Detailed summary
- Added `Hex` type definition in `src/types.ts`.
- Created initial release notes in `CHANGELOG.md`.
- Configured ESLint and TypeScript settings.
- Implemented `ledgerToAccount` function in `src/ledger-to-account.ts`.
- Added utility functions in `src/utils.ts`.
- Created test files for ledger interactions.
- Updated `README.md` with installation and usage instructions.
> The following files were skipped due to too many changes: `yarn.lock`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
Enter beta mode
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new configuration file, `.changeset/pre.json`,
which defines the pre-release mode and specifies version information for
various `@celo` packages.
### Detailed summary
- Added `.changeset/pre.json` file.
- Set `mode` to `"pre"` and `tag` to `"beta"`.
- Defined `initialVersions` for multiple `@celo` packages with specified
version numbers.
- Included an empty `changesets` array.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description Add warnings about the derivation path default changing in the future. as per https://forum.celo.org/t/deprecating-the-celo-derivation-path/9229 ### Other changes add derivationPath to the output ### Tested yes new `account:new` tests https://app.warp.dev/block/bYdy5uQ3WsAUT7rj1bT19l ### Related issues Prework for #352 ### Backwards compatibility yes unless you count the output of the command which we do not as it is designed for humans to read. ### Documentation improved! <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updates to the `@celo/celocli` and `@celo/cryptographic-utils` packages, including the addition of a warning about the new default ETH derivation path, improvements to the `NewAccount` command, and modifications to key generation functions. ### Detailed summary - `@celo/celocli`: Allow `account:new` command to run without a node. - Added warning about default ETH derivation path in future versions. - Updated `generateKeys`, `generateSeed`, and related functions with parameter documentation. - Adjusted `NewAccount` command to reflect new derivation path logic. - Updated test cases to verify new behavior with derivation paths. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
…#395) There was a bug where ledgers would return a INVALID DATA error when trying to transfer or interactive with a contract of one of the whitelisted gas fee tokens. or using a gas token to pay for gas. This occured while checking if the token was known in order to display human readble data while confirming on the ledger. The legacy 1.1.10 version of ledger app uses an older blob of signed data. it seems in this case the encoded data should NOT be prefixed by 0x. while in the newer it should be. this was not obvious and as automated tests are difficult when interacting with hw devices was missed. turned off test for cip66. Possibly we will remove later. ## related Issues fixes #394 fixes #353 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing issues related to token transfers and gas currency handling in the `celo` ecosystem, particularly with the `@celo/celocli` and `@celo/wallet-ledger` packages. It also improves error messages and adds a new method for providing token information. ### Detailed summary - Updated error messages in `packages/cli/src/transfer-stable-base.ts` for clarity on transfer affordability. - Fixed token information handling in `packages/sdk/wallets/wallet-ledger/src/ledger-signer.ts`. - Added `provideERC20TokenInformation` method to `LedgerSigner`. - Improved tests in `packages/sdk/wallets/wallet-ledger/src/ledger-wallet.test.ts` with mock implementations and inline snapshots. - Updated test suite to skip certain tests related to `cip66`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @celo/celocli@6.0.0-beta.0 ### Major Changes - [#339](#339) [`87223ba`](87223ba) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove support for reserve:\* commands. As foretold by <https://forum.celo.org/t/sunset-of-reserve-commands/8454> - [#343](#343) [`54741cc`](54741cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove commands identity:identifier, identity:get-attestations See <https://forum.celo.org/t/rfc-deprecation-of-celocli-identity-commands/8676> ### Patch Changes - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect message where the transfered token was used as gas token in the messaging but not in actuality - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix Transfering, exchanging cusd (and other fee tokens) and or using gasCurrency flag with ledger devices prior to 1.2 - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix: account:new can now be called without a node - Updated dependencies \[[`693f6e7`](693f6e7), [`5a0a922`](5a0a922), [`33ad4aa`](33ad4aa), [`4ef76eb`](4ef76eb), [`33ad4aa`](33ad4aa)]: - @celo/wallet-ledger@6.0.2-beta.0 - @celo/cryptographic-utils@5.1.1-beta.0 - @celo/contractkit@9.0.0-beta.0 - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/metadata-claims@1.0.0-beta.0 - @celo/explorer@5.0.13-beta.0 - @celo/governance@5.1.4-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/phone-utils@6.0.4-beta.0 - @celo/wallet-hsm-azure@6.0.2-beta.0 - @celo/wallet-local@6.0.2-beta.0 ## @celo/base@7.0.0-beta.0 ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ## @celo/contractkit@9.0.0-beta.0 ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Removes all exports under the lib/identity folder. These have been move to a new @celo/metadata-claims package and should be imported from there. Note that folder structure is also flattened slightly. so replace `@celo/contractkit/lib/identity/claims/` with `@celo/metadata-claims/lib/` example ```diff - import { createAccountClaim } from '@celo/contractkit/lib/identity/claims/account' + import { createAccountClaim } from '@celo/metadata-claims/lib/account' ``` ```diff - import { ContractKit, IdentityMetadataWrapper, newKitFromWeb3 } from '@celo/contractkit' - import { ClaimTypes } from '@celo/contractkit/lib/identity' + import { ContractKit, newKitFromWeb3 } from '@celo/contractkit' + import { ClaimTypes, IdentityMetadataWrapper } from '@celo/metadata-claims' ``` Note that Contractkit is Not a dependency. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-local@6.0.2-beta.0 ## @celo/metadata-claims@1.0.0-beta.0 ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Introducing @celo/metadata-claims These are a series of functions extracted from @celo/contractkit since they didnt strictly need depend on contractkit itsefl. Developers can now use IdentityMetadataWrapper with any js rpc library like ethers or viem or web3js without being forced to import ContractKit. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/utils@8.0.0-beta.0 ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 ## @celo/viem-account-ledger@1.0.0-beta.0 ### Major Changes - [#344](#344) [`6bba5e3`](6bba5e3) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Initial release ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 ## @celo/dev-utils@0.0.6-beta.0 ### Patch Changes - Updated dependencies \[]: - @celo/connect@6.0.3-beta.0 ## @celo/connect@6.0.3-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/cryptographic-utils@5.1.1-beta.0 ### Patch Changes - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/explorer@5.0.13-beta.0 ### Patch Changes - Updated dependencies \[[`33ad4aa`](33ad4aa), [`4ef76eb`](4ef76eb)]: - @celo/contractkit@9.0.0-beta.0 - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/governance@5.1.4-beta.0 ### Patch Changes - Updated dependencies \[[`33ad4aa`](33ad4aa), [`4ef76eb`](4ef76eb)]: - @celo/contractkit@9.0.0-beta.0 - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/explorer@5.0.13-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/keystores@5.0.12-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/wallet-local@6.0.2-beta.0 ## @celo/phone-utils@6.0.4-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 ## @celo/transactions-uri@5.0.12-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/wallet-base@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 ## @celo/wallet-hsm@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 ## @celo/wallet-hsm-aws@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-hsm@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-hsm-azure@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-hsm@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-hsm-gcp@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-hsm@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-ledger@6.0.2-beta.0 ### Patch Changes - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix issue where ledger running celo firmware app 1.1.10 could not send fee token transactions or perform and interactions with those contracts - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 - @celo/wallet-remote@6.0.2-beta.0 ## @celo/wallet-local@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/base@7.0.0-beta.0 - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 ## @celo/wallet-remote@6.0.2-beta.0 ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb)]: - @celo/utils@8.0.0-beta.0 - @celo/connect@6.0.3-beta.0 - @celo/wallet-base@6.0.2-beta.0 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating various Celo SDK packages to their beta versions, enhancing dependency management and incorporating new features. It includes significant version bumps and updates to changelogs across multiple packages. ### Detailed summary - Updated `@celo/base` to `7.0.0-beta.0` - Updated `@celo/connect` to `6.0.3-beta.0` - Updated `@celo/utils` to `8.0.0-beta.0` - Updated `@celo/dev-utils` to `0.0.6-beta.0` - Added multiple changelog entries for various packages - Introduced new `@celo/metadata-claims` package at `1.0.0-beta.0` - Updated `@celo/contractkit` to `9.0.0-beta.0` - Updated versions in `CHANGELOG.md` files across several packages > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### Description
It looks like our new package was not included in docs.
### Other changes
I narrowed which files were included in docs to just the functions and
constants actually exported publically
### Tested
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `@celo/viem-account-ledger` library by
updating type definitions, improving documentation, and modifying the CI
workflow to include all package directories.
### Detailed summary
- Updated `Hex` type definition in `types.ts`.
- Added module documentation in `modules.md`.
- Updated `typedoc.json` to include README and entry points.
- Modified CI workflow to track all package directories.
- Changed `LedgerAccount` type to be exported in `ledger-to-account.ts`.
- Added detailed documentation for `ledgerToAccount` function.
- Enhanced README with installation and usage instructions.
- Created detailed module documentation for `ledger-to-account`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
the gold command was always meant to be a temporary alias, and the
recover-old was intended to be a temporarily needed command.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on the removal of deprecated commands from the `celocli`
CLI tool, specifically `transfer:gold` and `account:recover-old`, along
with updates to related documentation.
### Detailed summary
- Removed the command `celocli transfer:gold`, replaced by `celocli
transfer:celo`.
- Removed the command `celocli account:recover-old`, intended for
migrating accounts from a beta version of Valora.
- Updated `package.json` to change the `clean` script.
- Updated documentation to reflect the removal of the above commands.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description
Template had too many sections which were never use. keep it simple.
keep it clean. keep it useful
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the pull request template in the
`.github/pull_request_template.md` file to enhance clarity and
structure, particularly in the explanation of changes and their
implications.
### Detailed summary
- Changed the prompt from "A few sentences describing the overall
effects and goals..." to "Tell us why these changes are being made".
- Updated section header from "### Other changes" to "#### Other
changes".
- Added a note to delete the "Other changes" section if none exist.
- Removed the "### Backwards compatibility" and "### Documentation"
sections from the template.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description
This ancient command harkens back to the days pre celo mainnet when we
were running a POA testnet.
It is not possible that this command is still usable as the method on
the Validator Contract it calls `forceDeaffiliateIfValidator` has a
`onlySlasher` modifier which check the caller against a set of slashers
stored on LockedGold slashers are stored as
`keccak256(abi.encodePacked(slasherIdentifier));` which must point to an
address in the registry. Therefore only slasher contracts can force
deaffiliation.
```
modifier onlySlasher() {
require(getLockedGold().isSlasher(msg.sender), "Only registered slasher can call");
_;
}
```
### Other changes
add pre commands to docs generation to ensure it runs correctly each
time.
upon running the now fixed docs commands the previously removed reserve
commands were removed finally
<!-- start pr-codex -->
### see
https://github.com/celo-org/celo-monorepo/blob/faca88f6a48cc7c8e6104393e49ddf7c2d7d20e3/packages/protocol/contracts/governance/Validators.sol#L585
https://github.com/celo-org/celo-monorepo/blob/master/packages/protocol/contracts/governance/LockedGold.sol#L422
---
## PR-Codex overview
This PR focuses on removing the `celocli validator:force-deaffiliate`
command from the CLI, which was only usable before the mainnet launch.
The documentation and related references have been updated to reflect
this removal and provide alternative commands for managing validators.
### Detailed summary
- Deleted `docs/command-line-interface/reserve.md`.
- Deleted `packages/cli/src/commands/validator/force-deaffiliate.ts`.
- Updated `generate_docs.sh` to remove documentation for the deleted
command.
- Removed references to `celocli validator:force-deaffiliate` from
`docs/command-line-interface/validator.md`.
- Added a note in the changeset about the removal of `celocli
validator:force-deaffiliate` and provided alternative commands.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
<!-- start pr-codex -->
## PR-Codex overview
This PR enhances support for `celo-legacy` and modern transactions
within the `ledger` wallet, including updates to transaction signing,
error handling, and test cases.
### Detailed summary
- Updated `package.json` for `@ledgerhq/hw-app-eth` to a specific
commit.
- Added `bundleDependencies` for `@ledgerhq/hw-app-eth`.
- Improved `signTransaction` method in `LedgerSigner` to handle `v`
values correctly.
- Refactored transaction recovery logic in tests for better validation.
- Enhanced error messages for legacy app version requirements.
- Updated tests to validate transaction signing for both legacy and
modern types.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @celo/celocli@6.0.0-beta.1 ### Major Changes - [#407](#407) [`3890220`](3890220) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove transfer:gold -- this was an old alias for transfer:celo which has the same functionality - [#412](#412) [`23d36cc`](23d36cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove `celocli validator:force-deaffiliate` This command was only ever usable pre mainnet launch. The force deaffiliate method it would call is only callable by one of the whitelisted Slasher Contracts. To force removal of validator with poor uptime use `celocli validator:downtime-slash` or to sever association with a validator from your group use `celocli validator:deaffiliate` - [#407](#407) [`3890220`](3890220) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove account:recover-old This was meant to be a temporary command for migrating account from a beta version of Valora to the release version. Please use a previous version of celocli if you need to make this one time recovery. ### Minor Changes - [`76045eb`](76045eb) Thanks [@shazarre](https://github.com/shazarre)! - BLS keys are now optional as being deprecated on L2, validator:register and releasecelo:authorize no longer require them in L2 context ### Patch Changes - Updated dependencies \[[`d988d31`](d988d31), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0)]: - @celo/wallet-ledger@6.0.2-beta.1 - @celo/wallet-local@6.0.2-beta.1 - @celo/contractkit@9.0.0-beta.1 - @celo/wallet-hsm-azure@6.0.2-beta.1 ## @celo/contractkit@9.0.0-beta.1 ### Minor Changes - [`76045eb`](76045eb) Thanks [@shazarre](https://github.com/shazarre)! - ValidatorsWrapper: add registerValidatorNoBls to allow registration without BLS keys which are not supported in L2 ### Patch Changes - [#400](#400) [`38fe4d0`](38fe4d0) Thanks [@shazarre](https://github.com/shazarre)! - Renames `getElected` and its usages to `getElectedAccounts` for `EpochManagerWrapper` - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-local@6.0.2-beta.1 ## @celo/dev-utils@0.0.6-beta.1 ### Patch Changes - [#400](#400) [`38fe4d0`](38fe4d0) Thanks [@shazarre](https://github.com/shazarre)! - Upgrades to latest devchain ## @celo/wallet-base@6.0.2-beta.1 ### Patch Changes - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger ## @celo/wallet-hsm-aws@6.0.2-beta.1 ### Patch Changes - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-base@6.0.2-beta.1 - @celo/wallet-hsm@6.0.2-beta.1 - @celo/wallet-remote@6.0.2-beta.1 ## @celo/wallet-hsm-azure@6.0.2-beta.1 ### Patch Changes - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-base@6.0.2-beta.1 - @celo/wallet-hsm@6.0.2-beta.1 - @celo/wallet-remote@6.0.2-beta.1 ## @celo/wallet-hsm-gcp@6.0.2-beta.1 ### Patch Changes - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-base@6.0.2-beta.1 - @celo/wallet-hsm@6.0.2-beta.1 - @celo/wallet-remote@6.0.2-beta.1 ## @celo/wallet-ledger@6.0.2-beta.1 ### Patch Changes - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-base@6.0.2-beta.1 - @celo/wallet-remote@6.0.2-beta.1 ## @celo/wallet-local@6.0.2-beta.1 ### Patch Changes - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-base@6.0.2-beta.1 ## @celo/wallet-remote@6.0.2-beta.1 ### Patch Changes - Updated dependencies \[[`d988d31`](d988d31)]: - @celo/wallet-base@6.0.2-beta.1 ## @celo/wallet-hsm@6.0.2-beta.1 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the versions of various `@celo` packages to `6.0.2-beta.1` and `0.0.6-beta.1`, along with some minor dependency upgrades and changelog entries. ### Detailed summary - Updated `@celo/wallet-base`, `@celo/wallet-hsm`, `@celo/wallet-remote`, and other packages to version `6.0.2-beta.1`. - Updated `@celo/dev-utils` to version `0.0.6-beta.1`. - Updated `@celo/contractkit` to version `9.0.0-beta.1`. - Added changelog entries for several packages indicating improvements and dependency updates. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Fixes the release process failing like here: https://github.com/celo-org/developer-tooling/actions/runs/11813422762/job/32910435812 <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `clean` script in the `packages/cli/package.json` file to ensure it forcefully removes the `tsconfig.tsbuildinfo` file by adding the `-f` flag to the `rm` command. ### Detailed summary - Modified the `clean` script: - Changed `rm tsconfig.tsbuildinfo` to `rm -f tsconfig.tsbuildinfo` to force the removal of the file. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Fixes the @celo/celocli install bug
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on changing the dependency management for several
packages to use npm instead of GitHub URLs, along with updating the
versioning of the `@celo/hw-app-eth` package across various files.
### Detailed summary
- Updated dependencies in `packages/viem-account-ledger/package.json` to
use `@celo/hw-app-eth` from npm.
- Removed GitHub URL references for `@ledgerhq/hw-app-eth` in
`packages/viem-account-ledger/package.json`.
- Adjusted imports in multiple files to use `@celo/hw-app-eth` instead
of `@ledgerhq/hw-app-eth`.
- Updated `yarn.lock` to reflect changes in dependencies.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description
the test take a while and the snapshots were very large with info that
was not actually what were were testing.
also Accidentally added better account authorize tests
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on enhancing the test cases for various
commands in the CLI, specifically around election showing, validator
deregistration, and account authorization. It improves the clarity of
logs and ensures proper cleanup of mocks.
### Detailed summary
- Changed `afterEach` in `election:show` test to clear mocks.
- Updated timeout constant from `LONG_TIMEOUT_MS` to
`EXTRA_LONG_TIMEOUT_MS` in `validator:deregister` tests.
- Added mock clearing for `console.log` and `console.error` in
`account:authorize` tests.
- Enhanced log output clarity for several test cases.
- Ensured consistent error handling with
`rejects.toThrowErrorMatchingInlineSnapshot`.
- Improved inline snapshots for better readability and accuracy in test
assertions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @celo/celocli@6.0.0-beta.2 ### Patch Changes - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`ee33677`](ee33677)]: - @celo/wallet-ledger@6.0.2-beta.2 - @celo/wallet-hsm-azure@6.0.2-beta.2 - @celo/wallet-local@6.0.2-beta.2 ## @celo/wallet-hsm-aws@6.0.2-beta.2 ### Patch Changes - Updated dependencies \[]: - @celo/wallet-base@6.0.2-beta.2 - @celo/wallet-hsm@6.0.2-beta.2 - @celo/wallet-remote@6.0.2-beta.2 ## @celo/wallet-hsm-azure@6.0.2-beta.2 ### Patch Changes - Updated dependencies \[]: - @celo/wallet-base@6.0.2-beta.2 - @celo/wallet-hsm@6.0.2-beta.2 - @celo/wallet-remote@6.0.2-beta.2 ## @celo/wallet-hsm-gcp@6.0.2-beta.2 ### Patch Changes - Updated dependencies \[]: - @celo/wallet-base@6.0.2-beta.2 - @celo/wallet-hsm@6.0.2-beta.2 - @celo/wallet-remote@6.0.2-beta.2 ## @celo/wallet-ledger@6.0.2-beta.2 ### Patch Changes - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[]: - @celo/wallet-base@6.0.2-beta.2 - @celo/wallet-remote@6.0.2-beta.2 ## @celo/wallet-local@6.0.2-beta.2 ### Patch Changes - Updated dependencies \[]: - @celo/wallet-base@6.0.2-beta.2 ## @celo/wallet-remote@6.0.2-beta.2 ### Patch Changes - Updated dependencies \[]: - @celo/wallet-base@6.0.2-beta.2 ## @celo/viem-account-ledger@1.0.0-beta.1 ### Patch Changes - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github ## @celo/wallet-base@6.0.2-beta.2 ## @celo/wallet-hsm@6.0.2-beta.2 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the versions of various Celo wallet packages to `6.0.2-beta.2` and `1.0.0-beta.1`, along with modifications in their changelogs and dependencies. ### Detailed summary - Updated `CHANGELOG.md` for multiple packages to include version `6.0.2-beta.2`. - Updated `package.json` files for `@celo/wallet-base`, `@celo/wallet-hsm`, `@celo/wallet-remote`, `@celo/wallet-local`, and others to version `6.0.2-beta.2`. - Added new dependency entries for `@celo/wallet-base@6.0.2-beta.2` in several packages. - Updated `@celo/viem-account-ledger` to version `1.0.0-beta.1`. - Added a patch note in `CHANGELOG.md` referencing a dependency change to use npm instead of GitHub. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### Description We had zero tests for building proposals. This adds them, switches the default abis to be v12 and also fixes some contracts not loading when building interactively since they are in sub directories. #### Other changes * move InteractiveProposalBuilder and ProposalBuilder to separate files. This makes the PR look bigger regrettably. but only one small change was made to these classes * sets up jest testing for governance package ### Tested as well as the brand new tests I tests this by hand with several contracts. ### Issues - Fixes #413 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `@celo/governance` and `@celo/celocli` packages, enhancing the proposal building features, fixing compatibility issues with contracts, and improving testing configurations. It also updates dependencies, particularly the `inquirer` library. ### Detailed summary - Patches for `@celo/governance` and `@celo/celocli`. - Fixes proposal building with contracts from `mento` and Solidity 0.8. - Updates `inquirer` library version from `7.0.5` to `7.3.3`. - Modifies `jest.config.js` for test matching patterns. - Introduces global setup in `jest_setup.ts`. - Adds improved transaction prompting in `InteractiveProposalBuilder`. - Updates `ProposalBuilder` for better transaction handling. - Adds tests for governance proposal building and interaction. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
### Description version conflict between the releases done on hotfix branch for wallets and for the master branch led to beta 6.0.2-beta.2 being head of the already released 6.0.2 which caused issues when installing. solution will be to set base version to 6.0.3 and continue betas from there
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @celo/celocli@6.0.0-beta.3 ### Minor Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Adds support for safe integration for L2 hotfix security council approvals - [#429](#429) [`5b02036`](5b02036) Thanks [@shazarre](https://github.com/shazarre)! - Removes L2 BLS keys support for account:authorize ### Patch Changes - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - fix governance:build-proposal with contracts from mento or which use solidity 0.8 - Updated dependencies \[[`7d42a05`](7d42a05), [`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485), [`7d42a05`](7d42a05)]: - @celo/governance@5.1.4-beta.1 - @celo/wallet-hsm-azure@6.0.3-beta.1 - @celo/wallet-ledger@6.0.3-beta.1 - @celo/wallet-local@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 - @celo/contractkit@9.0.0-beta.2 - @celo/explorer@5.0.13-beta.1 ## @celo/connect@6.1.0-beta.1 ### Minor Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Now CeloProvider can be wrapped in EIP-1193 partially compatible object (request + args) ## @celo/dev-utils@0.0.7-beta.1 ### Patch Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Adds actual Celo chain id when running anvil - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/connect@6.1.0-beta.1 ## @celo/contractkit@9.0.0-beta.2 ### Patch Changes - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-local@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 ## @celo/explorer@5.0.13-beta.1 ### Patch Changes - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/connect@6.1.0-beta.1 - @celo/contractkit@9.0.0-beta.2 ## @celo/governance@5.1.4-beta.1 ### Patch Changes - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - minor update to inquirer lib - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix being unable to use 08 and mento contracts with proposal builder - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/connect@6.1.0-beta.1 - @celo/contractkit@9.0.0-beta.2 - @celo/explorer@5.0.13-beta.1 ## @celo/transactions-uri@5.0.12-beta.1 ### Patch Changes - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/connect@6.1.0-beta.1 ## @celo/wallet-base@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/connect@6.1.0-beta.1 ## @celo/wallet-hsm@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict ## @celo/wallet-hsm-aws@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.3-beta.1 - @celo/wallet-base@6.0.3-beta.1 - @celo/wallet-hsm@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 ## @celo/wallet-hsm-azure@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.3-beta.1 - @celo/wallet-base@6.0.3-beta.1 - @celo/wallet-hsm@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 ## @celo/wallet-hsm-gcp@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.3-beta.1 - @celo/wallet-base@6.0.3-beta.1 - @celo/wallet-hsm@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 ## @celo/wallet-ledger@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-remote@6.0.3-beta.1 - @celo/wallet-base@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 ## @celo/wallet-local@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-base@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 ## @celo/wallet-remote@6.0.3-beta.1 ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`fb08485`](fb08485)]: - @celo/wallet-base@6.0.3-beta.1 - @celo/connect@6.1.0-beta.1 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the versions of various `@celo` packages and their dependencies across the codebase, ensuring compatibility and introducing minor fixes and improvements. ### Detailed summary - Updated `@celo/dev-utils` from `0.0.7-beta.0` to `0.0.7-beta.1` - Updated `@celo/connect` from `6.0.3-beta.0` to `6.1.0-beta.1` - Updated `@celo/contractkit` from `9.0.0-beta.1` to `9.0.0-beta.2` - Updated wallet packages to `6.0.3-beta.1` - Updated `@celo/governance` from `5.1.4-beta.0` to `5.1.4-beta.1` - Updated changelogs for various packages to reflect version bumps and patch changes. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
with #435 merged and released the base versions need to be bumped <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the version numbers of various `@celo` packages from `6.0.3-beta.1` to `6.0.4-beta.0` across multiple package files, reflecting the latest improvements and dependencies. ### Detailed summary - Updated `version` of `@celo/wallet-base` to `6.0.4-beta.0`. - Updated `@celo/wallet-local` to `^6.0.4-beta.0` in multiple packages. - Updated `@celo/wallet-hsm` to `^6.0.4-beta.0` in multiple packages. - Updated `@celo/wallet-remote` to `^6.0.4-beta.0` in multiple packages. - Updated `@celo/wallet-ledger` to `^6.0.4-beta.0`. - Updated `@celo/wallet-hsm-azure` to `^6.0.4-beta.0`. - Updated `@celo/wallet-hsm-aws` to `^6.0.4-beta.0`. - Updated `@celo/wallet-hsm-gcp` to `^6.0.4-beta.0`. - Updated `@celo/celocli` from `5.2.1` to `5.2.3` in `.changeset/pre.json`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
### Description Corrected minor spelling errors in documentation files. These changes improve the clarity and accuracy of the content. #### Other changes Fixed the typo in the RELEASE.md file: corrected "significant" to the correct spelling. Fixed the typo in the docs/command-line-interface/account.md file: corrected "beneficary" to "beneficiary". ### Related issues - replaces #433 -- some of our ci seems to not run on forked requests namely foundry <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on correcting typographical errors related to the word "beneficiary" across various files, ensuring consistency and clarity in documentation and code comments. ### Detailed summary - Corrected "benficiary" to "beneficiary" in comments and descriptions in: - `packages/sdk/contractkit/src/wrappers/Accounts.ts` - `packages/cli/src/commands/account/register-data-encryption-key.ts` - `packages/cli/src/commands/account/delete-payment-delegation.ts` - `packages/sdk/explorer/fixtures/contract.metadata.json` - `docs/sdk/contractkit/classes/wrappers_Accounts.AccountsWrapper.md` - `RELEASE.md` - `docs/command-line-interface/account.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Cypher Pepe <125112044+cypherpepe@users.noreply.github.com>
### Description bump abis and devchain and therefore update snapshots due to changes in generated addresses. There is no official pre-audit release so basing on the last published release #### Other changes n/a ### Tested n/a ### Related issues - Fixes #445 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating dependencies and making adjustments to various test files and snapshots related to the `@celo` packages, specifically addressing version bumps and changes in member updates. ### Detailed summary - Bumped `@celo/abis-12` from `12.0.0-canary.60` to `12.0.0-canary.66`. - Updated `@celo/devchain-anvil` from `12.0.0-canary.33` to `12.0.0-canary.39`. - Changed `membersUpdated` value from `1729165064` to `1731689623` in test files. - Adjusted `frozenReserveGoldStartDay` from `20013` to `20042` in multiple test files. - Updated implementation addresses in snapshots for `FeeHandler` in `contracts.test.ts.snap` and `contracts-l2.test.ts.snap`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
### Description
Various coverage improvements
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the `codecov` dependency version, modifies the
`codecov.yml` configuration, and adds tests for the `Balance` command in
the `packages/cli/src/commands/account/balance.test.ts` file.
### Detailed summary
- Updated `codecov` version from `3.6.5` to `3.8.3` in `package.json`
and `yarn.lock`.
- Changed `codecov.yml` configuration settings, including:
- Updated `threshold` to `0%` and set `base` to `auto`.
- Added `only_pulls` option and modified `comment` layout.
- Introduced component management rules for various components.
- Added tests for the `Balance` command, covering:
- Displaying account balances in multiple currencies.
- Displaying account balances in a specified currency after topping up.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
### Description it was not at all clear for cli users how to use the --node flag especially that it had aliases for common nodes. This makes that obvious #### Other changes By making useLedger and privateKey no longer hidden users will be able to know how to provide them ### Tested add new tests! ### Related issues - Fixes #357 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `celocli` command-line interface by adding support for `--useLedger` and `--ledgerAddresses` flags across various commands, improving user experience for those utilizing Ledger wallets. ### Detailed summary - Added `--useLedger` flag to multiple commands to support Ledger wallet integration. - Introduced `--ledgerAddresses` flag to retrieve addresses from Ledger. - Updated documentation to reflect new flags and their usage. - Marked certain flags as hidden for improved clarity. > The following files were skipped due to too many changes: `docs/command-line-interface/transfer.md`, `docs/command-line-interface/election.md`, `docs/command-line-interface/validatorgroup.md`, `docs/command-line-interface/exchange.md`, `docs/command-line-interface/lockedgold.md`, `docs/command-line-interface/validator.md`, `docs/command-line-interface/releasecelo.md`, `docs/command-line-interface/governance.md`, `docs/command-line-interface/account.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Leszek Stachowski <leszek.stachowski@clabs.co>
### Description Improves the coverage of the different formats `v` can have when returned from a ledger device, and backports the fixes done in #408 but for the viem package. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the handling of the `v` value in signatures from a Ledger device, enhancing type handling, and refining overall code structure for better clarity and functionality. ### Detailed summary - Updated `.gitignore` to include `lib-es/`. - Improved handling of `v` from Ledger signatures. - Refactored imports to use default imports where applicable. - Enhanced type definitions for `Eth` and `TransportNodeHid`. - Modified `signTransaction` to handle malformed `v` values. - Updated tests to cover new scenarios for `v` values. - Refactored `mockLedger` to improve structure and clarity. - Improved error handling and logging for better debugging. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
🦋 Changeset detectedLatest commit: 9558b56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13736787 | Triggered | Generic Password | 416ed00 | packages/sdk/wallets/wallet-rpc/src/rpc-wallet.test.ts | View secret |
| 13736787 | Triggered | Generic Password | 33ad4aa | packages/sdk/wallets/wallet-rpc/lib/rpc-wallet.test.js | View secret |
| 14107627 | Triggered | Generic High Entropy Secret | 5a0a922 | packages/cli/src/commands/account/new.test.ts | View secret |
| 14107625 | Triggered | Generic High Entropy Secret | 5a0a922 | packages/cli/src/commands/account/new.test.ts | View secret |
| 14107626 | Triggered | Generic High Entropy Secret | 5a0a922 | packages/cli/src/commands/account/new.test.ts | View secret |
| 14107624 | Triggered | Generic High Entropy Secret | 5a0a922 | packages/cli/src/commands/account/new.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
### Description The command would fail not very gracefully if not passing --estimate This is is for L1 only and does not resolve - #415 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `rewards:show` command by adding error handling for missing estimates and improving test coverage for various scenarios, including valid and invalid validators and voters. ### Detailed summary - Added error handling for missing estimates in `show.ts`. - Updated tests in `show-l2.test.ts` for the `rewards:show` command. - Enhanced `show.test.ts` with tests for: - Default behavior without arguments. - Error handling for missing trie nodes. - Validation checks for both validators and voters. - Logging outputs for successful and failed checks. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore mme