Skip to content

Conversation

@aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Oct 30, 2025

Description

cli

  • account:proof-of-possession is not completely migrated to viem,
  • account:authorize is partially migrated (attestation not because its deprecated)

anyone can generated a PoP now with just the actions + core packages.

Other changes

back to beta mode

Tested

new tests and existing but need more qaing

How to QA

generate proof of possession (account:proof-of-possession), validate it with account:verify-proof-of-possession and account:authorize

Related issues


PR-Codex overview

This PR focuses on enhancing the proof-of-possession functionality in the Celo blockchain ecosystem, introducing new utilities for generating and parsing signatures, and refactoring existing code to utilize the viem library instead of web3.

Detailed summary

  • Added generateProofOfKeyPossession, generateProofOfKeyPossessionLocally, and parseSignatureOfAddress functions in @celo/actions.
  • Refactored account:proof-of-possession and account:authorize commands to use viem.
  • Introduced isValidator function in validators.ts.
  • Updated signature parsing and serialization in core package.
  • Added tests for proof-of-possession functionalities.
  • Minor updates to CLI commands and dependencies.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

aaronmgdr and others added 4 commits October 30, 2025 13:14
- Extract proof-of-possession functionality to dedicated module in actions package
- Update account authorize command to use new viem-based authorization functions
- Add authorizeVoteSigner and authorizeValidatorSigner functions using viem
- Maintain compatibility with existing proof-of-possession signatures
- Update changeset to reflect both proof-of-possession and authorize command changes
- Add @celo/core dependency to CLI package for proof-of-possession parsing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: a01019f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@celo/actions Minor
@celo/core Minor
@celo/celocli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

size-limit report 📦

Path Size
require('@celo/actions') (cjs) 193.63 KB (+95.88% 🔺)
import * from '@celo/actions' (esm) 43.22 KB (+83.53% 🔺)
import { resolveAddress } from '@celo/actions' (esm) 23.5 KB (+0.03% 🔺)
import { getGasPriceOnCelo } from '@celo/actions' (esm) 74 B (+1.37% 🔺)
import { getAccountsContract } from '@celo/actions/contracts/accounts' (esm) 46.14 KB (+0.08% 🔺)
import * from '@celo/actions/staking' (esm) 50.72 KB (+0.14% 🔺)
import { authorizeVoteSigner } from '@celo/actions/contracts/accounts' (esm) 24.65 KB (+100% 🔺)
import * from '@celo/actions/authorization' (esm) 26.44 KB (+100% 🔺)

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 45.52846% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.22%. Comparing base (5dac99b) to head (a01019f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   69.63%   69.22%   -0.42%     
==========================================
  Files         150      153       +3     
  Lines        7071     7193     +122     
  Branches     1156     1177      +21     
==========================================
+ Hits         4924     4979      +55     
- Misses       2082     2130      +48     
- Partials       65       84      +19     
Components Coverage Δ
celocli ∅ <ø> (∅)
sdk 69.15% <ø> (ø)
wallets 73.14% <ø> (ø)
viem-sdks 94.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants