-
Notifications
You must be signed in to change notification settings - Fork 31
Bring Proof of Possession generation (for vote signer registration) to Mondo #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aaronmgdr
wants to merge
8
commits into
master
Choose a base branch
from
aaronmdr/poppop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parsingSignatures
…ad of web3 based functions
- Extract proof-of-possession functionality to dedicated module in actions package - Update account authorize command to use new viem-based authorization functions - Add authorizeVoteSigner and authorizeValidatorSigner functions using viem - Maintain compatibility with existing proof-of-possession signatures - Update changeset to reflect both proof-of-possession and authorize command changes - Add @celo/core dependency to CLI package for proof-of-possession parsing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: a01019f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 69.63% 69.22% -0.42%
==========================================
Files 150 153 +3
Lines 7071 7193 +122
Branches 1156 1177 +21
==========================================
+ Hits 4924 4979 +55
- Misses 2082 2130 +48
- Partials 65 84 +19
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cli
anyone can generated a PoP now with just the actions + core packages.
Other changes
back to beta mode
Tested
new tests and existing but need more qaing
How to QA
generate proof of possession (
account:proof-of-possession), validate it withaccount:verify-proof-of-possessionandaccount:authorizeRelated issues
PR-Codex overview
This PR focuses on enhancing the proof-of-possession functionality in the Celo blockchain ecosystem, introducing new utilities for generating and parsing signatures, and refactoring existing code to utilize the
viemlibrary instead ofweb3.Detailed summary
generateProofOfKeyPossession,generateProofOfKeyPossessionLocally, andparseSignatureOfAddressfunctions in@celo/actions.account:proof-of-possessionandaccount:authorizecommands to useviem.isValidatorfunction invalidators.ts.corepackage.