chore(socket): extrac ReqDriver connection manager #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
commented
Dec 11, 2025
| conn_ctl, | ||
| Arc::clone(&self.state.transport_stats), | ||
| self.options.auth_token.clone(), | ||
| span.clone(), |
Contributor
Author
There was a problem hiding this comment.
right now ConnManager and driver use the same span. I can make two separate ones if it's cleaner?
merklefruit
force-pushed
the
nico/chore/cleanup-reqdriver-poll
branch
from
8b9cc29 to
147515d
Compare
merklefruit
force-pushed
the
nico/chore/cleanup-reqdriver-poll
branch
from
147515d to
44f3f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReqDriverconnection management #125ReqSocketsoptions are unused #114 by addingretry_attemptsusage