Use reactions for confirmation when appropriate #272
Conversation
isomorpheme
force-pushed
the
reactions
branch
3 times, most recently
from
c9ce7a7 to
b0b5171
Compare
isomorpheme
force-pushed
the
reactions
branch
from
b0b5171 to
531c27c
Compare
isomorpheme
force-pushed
the
reactions
branch
from
531c27c to
80faf59
Compare
|
Example of my local hoff using reactions: isomorpheme/sandbox#2 |
rlycx
left a comment
rlycx
left a comment
There was a problem hiding this comment.
source code itself looks good, but could you add a test case for this (or point me to something that tests this particular feature if i overlooked it)?
I already added test cases here: https://github.com/channable/hoff/pull/272/files#diff-5057de5eb61e3ca52c8f206f6964e0486e9257418d5d39ab89f3cfaaf6e97839R913-R992 Very understandable if you missed that though, the diff is unfortunately large & has a lot of repetition. |
|
@OpsBotPrime merge |
|
Pull request approved for merge by @isomorpheme, waiting for rebase behind one pull request. |
Approved-by: isomorpheme Priority: Normal Auto-deploy: false
|
Speculatively rebased as 30575d7 behind 1 other PR, waiting for CI … |
|
CI job 🟡 started. |
3 participants
Closes #198. This ended up being more work than you'd expect, and due to a seeming omission from GitHub's API, we can't send a reaction in every case, in which case we fall back to an old-fashioned comments. I also decided to fall back to posting a comment if the PR isn't immediately at the top of the merge queue, but maybe there's no need to be that informative.
Depends on haskell-github/github#509 to be able to use the Reactions API. I've added that as a patch to the Nix overlay; if there's contributors that want to work without Nix then it should be doable to get that patch by adding to
cabal.projectas well.