Skip to content

Issue #17449: Add XDocs example for FinalLocalVariableCheck validateU… #18306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ekansh0unofficial wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #17449: Add XDocs example for FinalLocalVariableCheck validateU… #18306

ekansh0unofficial wants to merge 1 commit into from
+42 −1

Conversation

@ekansh0unofficial
Copy link
Contributor

@ekansh0unofficial ekansh0unofficial commented Dec 15, 2025 •
edited
Loading

Issues #17449 : Adds an XDocs example covering validateUnnamedVariables for FinalLocalVariableCheck and removes it from the suppression list.

@ekansh0unofficial ekansh0unofficial force-pushed the issue-17449-final-local-variable-xdocs branch 4 times, most recently from 216db80 to 941e78b Compare December 15, 2025 16:26
@ekansh0unofficial
Copy link
Contributor Author

ekansh0unofficial commented Dec 16, 2025 •
edited
Loading

CI continues to show intermittent failures across different jobs (JDK/OS variants) . No code changes since last successful runs.

@ekansh0unofficial ekansh0unofficial force-pushed the issue-17449-final-local-variable-xdocs branch from 95d5ff2 to 1b88dd0 Compare December 16, 2025 04:02
romani
romani requested changes Dec 17, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single commit please.

item to improve:

...les/resources/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/Example5.java
{
static void test() {
int _ = 1;
// violation above, 'Variable '_' should be declared final'
Copy link
Member

@romani romani Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this test method to all Examples.
please make Example5 as a copy of Example4, and just change location of comments.

@ekansh0unofficial ekansh0unofficial force-pushed the issue-17449-final-local-variable-xdocs branch 2 times, most recently from 9b876f8 to 82c17ee Compare December 18, 2025 03:44
@ekansh0unofficial ekansh0unofficial force-pushed the issue-17449-final-local-variable-xdocs branch from 82c17ee to 4a8c2cc Compare December 18, 2025 03:55
@ekansh0unofficial
Copy link
Contributor Author

ekansh0unofficial commented Dec 18, 2025

I rebased this branch on the latest upstream master and reproduced the failing CI jobs locally.
no-exception-hbase passes locally.
no-exception-samples-gradle reports the same Checkstyle violations locally on upstream master and on this branch (e.g. NewlineAtEndOfFile, ReturnNullInsteadOfBoolean), but no exception is thrown and the Gradle build completes successfully.

Could you please advise on how to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ekansh0unofficial @romani