python: add installer option #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MSI checksum is set, then the builder will download the Python installer, install Python at a temp location, then move the folder to the known location. At the end, the Python package will be uninstalled. Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
commented
Dec 5, 2025
| [string]$VSRedistDir = "${ENV:ProgramFiles(x86)}\Common Files\Merge Modules", | ||
| [string]$SignTimestampUrl = "http://timestamp.digicert.com?alg=sha256" | ||
| [string]$SignTimestampUrl = "http://timestamp.digicert.com?alg=sha256", | ||
| [string]$PythonMsiChecksum = $null |
Member
Author
There was a problem hiding this comment.
Maybe it is worth adding a boolean flag?
ader1990
commented
Dec 5, 2025
| throw "$python_template_dir folder already exists" | ||
| } | ||
|
|
||
| $pythonInstallerPath = Join-Path (Resolve-Path "${python_template_dir}/..").Path "/python-${pythonVersion}${platformSuffix}.exe" |
Member
Author
There was a problem hiding this comment.
use parent path instead of ..
ader1990
commented
Dec 5, 2025
| if ($PythonMsiChecksum) { | ||
| DownloadInstall-PythonMsi $platform $python_template_dir $pythonversion $PythonMsiChecksum | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
After the MSI build is done, the python_template_dir can be cleaned up as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MSI checksum is set, then the builder will download the Python installer, install Python at a temp location, then move the folder to the known location. At the end, the Python package will be uninstalled.