clarifies currently ambigious attempts field of queue message #27265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing info that the current attempt immediately makes every message start with 1, not 0.
xdivby0
requested review from
a team,
elithrar,
harshil1712,
jonesphillip and
mia303
as code owners
github-actions
bot
added
the
product:queues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the attempts field is quickly misinterpreted to represent all previous attempts, making every message start at 0 and count up from there.
The change is minimal and eliminates this ambiguity, making clear that messages start from one, meaning it includes the current attempt.
Summary
Add "(including the current attempt)" behind the existing sentence.
Documentation checklist