feat: Add new_mtls for HttpProxy #784
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix to resolve #783
We expose a
new_mtlsmethod for creating a HttpProxy with a client_cert_key to enable mTLS peers.AFAIK there is currently no other way to set or modify the client_cert_key field. So that small change enables to actually use mTLS HttpPeers, even if the foundations (with the field) been there for a while...
This works well for my own usecase!
Let me know if anyone prefers another approach, i.e a public setter instead of constructor. Or just a different name.
Also, looking at some previous commits it doesnt feel like this sort of changes requires tests to be written. But let me know if thats a wrong assumption.
For anyone looking to use mTLS with a self signed server certificate will you need to modify the PeerOptions too.
Here is an example from my own project: