Skip to content

Conversation

@hodanoori
Copy link
Contributor

@hodanoori hodanoori commented Jan 6, 2026

Summary

Adds a dedicated image details page to support remediation activities. The page shows image information and vulnerabilities, and will later include separate lists for remediated and non-remediated issues.
Previously, image details were shown in a panel overlay. This change moves them to a full-page route /services/$service/$image to provide more space and structure for future remediation features.

Changes Made

  • Created new image details page route at /services/$service/$image with loader and breadcrumb configuration
  • Refactored ImageDetails component structure by moving it to ImageDetails/index.tsx folder and reorganizing related components
  • Updated Service component to support nested routes with conditional rendering of for child routes
  • Enhanced navigation persistence to save and restore service and image details when switching between "Services" and "Vulnerabilities" tabs
  • Updated service overview panel to navigate to image details page when clicking "Show Details" button on individual images
  • Fixed TypeScript deprecation warnings by replacing ApolloQueryResult with generated GetImagesQueryResult type
  • Fixed ESLint errors by extracting inline component function to named function for proper hooks analysis

Related Issues

Screenshots (if applicable)

7664A9B8-D64E-480A-BF07-E8567F906EBD

Testing Instructions

Go to the “Services” tab and click the “Show Details” button on any service in the list. You should be navigated to the service details page. Verify that the breadcrumb shows Services > [selected service name].

Then select an image in the image list. You should be navigated to the image details page, where the detailed information for that image is shown at the top of the page and a list of vulnerabilities is displayed below it. Check that the Breadcrumb shows the selected image name correctly.

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@hodanoori hodanoori requested a review from a team as a code owner January 6, 2026 13:06
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

🦋 Changeset detected

Latest commit: 5b80493

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hodanoori hodanoori self-assigned this Jan 6, 2026
@hodanoori hodanoori added the heureka Heureka related issues label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-01-08 08:38 UTC

Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just one comment.

andypf
andypf previously approved these changes Jan 6, 2026
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah!! 🚀 Just 1 comment

Copy link
Contributor

@taymoor89 taymoor89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! 👍

@hodanoori hodanoori merged commit 0d62d35 into main Jan 8, 2026
16 checks passed
@hodanoori hodanoori deleted the hoda-heureka-image-details-page branch January 8, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

heureka Heureka related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants