-
Notifications
You must be signed in to change notification settings - Fork 1
feat(heureka): adds image details page #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5b80493 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
andypf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just one comment.
ArtieReus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah!! 🚀 Just 1 comment
taymoor89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! 👍
Summary
Adds a dedicated image details page to support remediation activities. The page shows image information and vulnerabilities, and will later include separate lists for remediated and non-remediated issues.
Previously, image details were shown in a panel overlay. This change moves them to a full-page route
/services/$service/$imageto provide more space and structure for future remediation features.Changes Made
services/$service/$imagewith loader and breadcrumb configurationImageDetailscomponent structure by moving it to ImageDetails/index.tsx folder and reorganizing related componentsServicecomponent to support nested routes with conditional rendering of for child routesApolloQueryResultwith generatedGetImagesQueryResulttypeRelated Issues
Screenshots (if applicable)
Testing Instructions
Go to the “Services” tab and click the “Show Details” button on any service in the list. You should be navigated to the service details page. Verify that the breadcrumb shows Services > [selected service name].
Then select an image in the image list. You should be navigated to the image details page, where the detailed information for that image is shown at the top of the page and a list of vulnerabilities is displayed below it. Check that the Breadcrumb shows the selected image name correctly.
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.