-
Notifications
You must be signed in to change notification settings - Fork 6
Improve documentation and examples #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request would run green after the pull request #16 will be merged. I would rebase this pull request afterwards. |
d06a4db to
cce739e
Compare
|
This pull request is rebased now and ready for a review. 😎 |
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for looking into this! Here's a minor suggestion while we're at it:
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for the update, changes LGTM! ![]()
Builds on top of #11 and #8.
References: clue/reactphp-tar#20 and clue/reactphp-sqlite#43.