Skip to content

changefeedccl: validate avro_schema_prefix follows Avro naming rules #159869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KeithCh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changefeedccl: validate avro_schema_prefix follows Avro naming rules #159869

KeithCh wants to merge 1 commit into from
+72 −0

Conversation

@KeithCh
Copy link
Contributor

@KeithCh KeithCh commented Dec 18, 2025 •
edited
Loading

An invalid avro_schema_prefix caused changefeeds to hang indefinitely.
This validates that avro_schema_prefix follows Avro naming rules at
statement time.

Release note: Invalid avro_schema_prefix is now caught during statement
time. The prefix must start with [A-Za-z_] and subsequently contain only
[A-Za-z0-9_], as specified in the avro specification
https://avro.apache.org/docs/1.8.1/spec.html

Part of: https://github.com/cockroachlabs/support/issues/3513

@KeithCh KeithCh requested a review from log-head December 18, 2025 23:03
@KeithCh KeithCh requested a review from a team as a code owner December 18, 2025 23:03
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 18, 2025

This change is Reviewable

@KeithCh KeithCh force-pushed the validate_avro_schema_prefix branch 2 times, most recently from b094249 to 85fd684 Compare December 18, 2025 23:06
@KeithCh KeithCh changed the title changefeed: validate avro_schema_prefix follows Avro naming rules changefeedccl: validate avro_schema_prefix follows Avro naming rules Dec 18, 2025
@KeithCh KeithCh force-pushed the validate_avro_schema_prefix branch from 85fd684 to 46c226a Compare December 18, 2025 23:06
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Dec 18, 2025
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@KeithCh
changefeedccl: validate avro_schema_prefix follows Avro naming rules
21d5488 
An invalid avro_schema_prefix caused changefeeds to hang indefinitely.
This validates that avro_schema_prefix follows Avro naming rules at
statement time.

Release note: Invalid avro_schema_prefix is now caught during statement
time. The prefix must start with [A-Za-z_] and subsequently contain only
[A-Za-z0-9_], as specified in the avro specification
https://avro.apache.org/docs/1.8.1/spec.html

Part of: cockroachlabs/support#3513
@KeithCh KeithCh force-pushed the validate_avro_schema_prefix branch from 46c226a to 21d5488 Compare December 18, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@log-head log-head Awaiting requested review from log-head

Assignees

No one assigned

Labels

o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KeithCh @cockroach-teamcity