Skip to content

Conversation

@marcos5ilva
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Fixed Issues

Changes

  • Create a syllabus folder in the project root
  • Create a markdown file for the Syllabus
  • Develop an outline for the HTM5 Module 1 content
  • Register the outline content in the Syllabus file

PR Checklist

  • Does your PR contain relevant tests that pass?
  • Is your code linted? yarn lint or yarn lint:fix
  • Does your code build correctly in ALL projects? yarn build

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #317 into develop will increase coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #317      +/-   ##
===========================================
+ Coverage    83.05%   85.62%   +2.56%     
===========================================
  Files           71       71              
  Lines         1216     1287      +71     
  Branches        60       68       +8     
===========================================
+ Hits          1010     1102      +92     
+ Misses         186      155      -31     
- Partials        20       30      +10     
Flag Coverage Δ
#unittests 85.62% <ø> (+2.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...api/src/UserPreferences/UserPreferences.service.ts 58.33% <0.00%> (-16.67%) ⬇️
packages/api/src/User/User.resolver.ts 85.29% <0.00%> (-11.49%) ⬇️
packages/api/src/User/User.service.ts 93.75% <0.00%> (-6.25%) ⬇️
packages/api/src/User/index.ts 100.00% <0.00%> (ø)
packages/api/src/Module/index.ts 100.00% <0.00%> (ø)
packages/api/src/User/User.entity.ts 100.00% <0.00%> (ø)
packages/api/src/UserModule/index.ts 100.00% <0.00%> (ø)
packages/api/src/UserModule/UserModule.resolver.ts 69.23% <0.00%> (ø)
packages/api/src/Module/Module.resolver.ts 90.47% <0.00%> (+4.76%) ⬆️
packages/api/src/Friend/Friend.service.ts 95.23% <0.00%> (+4.76%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c86bd8...a17075b. Read the comment docs.

@tristanMatthias
Copy link
Contributor

So what's the status on this one @marcos5ilva? It seems to be a combination of a few things. Can we combine it with some of the other syllabus work going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syllabus: HTML5 Content Module 1 Overview

4 participants