Skip to content

HTML Lesson 3: Common HTML Elements #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wdaimee wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

HTML Lesson 3: Common HTML Elements #353

wdaimee wants to merge 2 commits into from

Conversation

@wdaimee
Copy link
Contributor

@wdaimee wdaimee commented Oct 4, 2020 •
edited
Loading

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Fixed issues (PRs without this will not be accepted)

Changes

  • added lesson 3 content

PR Checklist

  • Does your PR contain relevant tests that pass?
  • Is your code linted? yarn lint or yarn lint:fix
  • Does your code build correctly in ALL projects? yarn build

@wdaimee wdaimee added the project:api Task for the back-end API label Oct 4, 2020
suzynakayama
suzynakayama requested changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@suzynakayama suzynakayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the lesson! Just a few minor misses to fix before we can merge.

@wdaimee
Copy link
Contributor Author

wdaimee commented Oct 15, 2020

Hi @suzynakayama,

Thank you for taking a look at the lesson! I made the corrections as you advised and just submitted a commit for the changes.

Thanks!

suzynakayama
suzynakayama approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@suzynakayama suzynakayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @wdaimee, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suzynakayama suzynakayama suzynakayama approved these changes

@tristanMatthias tristanMatthias Awaiting requested review from tristanMatthias

Assignees

No one assigned

Labels

project:api Task for the back-end API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTML Module 1 - Lesson 3: Common HTML Elements

3 participants

@wdaimee @suzynakayama