-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(encryption): Add previous keys fallback feature #9853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
patel-vansh
wants to merge
17
commits into
codeigniter4:4.7
Choose a base branch
from
patel-vansh:feat/previous-enc-keys
base: 4.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+169
−18
Draft
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7837aa0
feat(encryption): Add environment variables in env file for previous …
patel-vansh be93000
feat(encryption): Add previous keys fallback variables in encryption …
patel-vansh 972ad6e
feat(encryption): Parse the previous keys fallback variables in BaseC…
patel-vansh 486bf57
feat(encryption): Implement the main logic of using previous keys if …
patel-vansh 5f45c6f
feat(encryption): Add the key names in SodiumHandler.php
patel-vansh 55ed3a7
feat(encryption): Add previous key initialization in Encryption.php
patel-vansh 5e53f06
refactor: cs fix
patel-vansh 68e05ba
refactor: fix static analysis problems
patel-vansh 772bc29
feat(encryption): Change previousKeys to a comma-separated string for…
patel-vansh 2ad2e97
feat(encryption): Remove previousKeysFallbackEnabled property and rel…
patel-vansh c3f5bae
refactor: cs fix
patel-vansh 97e32f4
refactor: fix FunctionFirstClassCallableRector
patel-vansh 6a8694f
refactor: add #[SensitiveParameter] whenever necessary
patel-vansh 2f58622
refactor: add support for both string and array $previousKeys and mad…
patel-vansh 628c41d
refactor: cs fix
patel-vansh a1902e1
refactor: fix static code analysis problems
patel-vansh e1331e2
refactor: changed array<string> to list<string>
patel-vansh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A string value (
is_string($params)) should also be treated as a key.