-
Notifications
You must be signed in to change notification settings - Fork 35
fix: support finding ssh process by port on macos sequoia #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b1eda3 to
facb2eb
Compare
matifali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @ethanndickson
86f3458 to
f6c1272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that find-process execs netstat instead of reading /proc directly. Although, maybe that is not possible on macOS?
In any case, looks good to me. If we ever implement our own connection code we will be able to get the PID more easily. 🤞
|
Will need someone else to merge, as I don't have permission! |
This is becoming more than a want now, and we may actually need this soon. |
|
@ethanndickson, I am noticing a better reconnection flow after this PR. When my device returns from sleep, VS Code auto-reconnects without me pressing the reload button. This may probably solve #413. |
|
The upstream library fixed the issue, so we may consider switching to that again. |

Relates to #361.
This brings back the connection indicator, at least on macOS Sequoia.

The indicator is populated from a file named
<sshPID>.json. The library we were using to find that PID,find-processhasn't been updated for Sequoia.Full explanation of the necessary change can be found in an umerged PR for that library:
yibn2008/find-process#78
This change was never merged, so I've forked it into our org for now. When it gets upstreamed we can switch back.