Tiny fix that shows up only when running an experiment with the -O3 compilation flag
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A variable was declared and defined under a scope that was disregarded later on when the variable was used again. This expression was never executed: > oc_params.nprocs = num_traces_of_job[lid.job]; because `oc_params.nprocs` was never executed. The line: > params = (char*)&oc_params; after was copying the `oc_params` variable into a new variable to be used later. `oc_params` is not guaranteed to exist after the scope closes, and this would provoke a segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny fix should be merged into "master". It does not alter the behavior of CODES. It is a fix to a bug that appeared.
The bug in question is:
Improper use of variable declaration inside a scope provokes segfault on optimized code
-O3A variable was declared and defined under a scope that was disregarded. Later on, outside of the scope a reference to the variable was used again causing a segfault.
This expression was never executed (optimized out):
because
oc_params.nprocswas never used within the scope ofoc_params.Later on, a pointer to
oc_paramstries to accessnprocsbut this contains only garbage, and this triggers a segfault down the line.