-
-
Notifications
You must be signed in to change notification settings - Fork 18
Fix typo: pendingRquests → pendingRequests #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: codingjoe <1772890+codingjoe@users.noreply.github.com>
codingjoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## safari #360 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 8 8
Lines 223 223
=======================================
Hits 219 219
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a critical typo in the property name used to track pending upload requests, changing pendingRquests to pendingRequests. The typo caused Promise.all() to wait on undefined instead of the actual pending requests array, breaking the upload flow in Safari's custom element implementation.
- Fixed the typo in the
submitHandler()method where pending requests are awaited - Fixed the typo in the
uploadHandler()method where the pending requests array is initialized and populated - Updated test assertions to use the corrected property name
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| s3file/static/s3file/js/s3file.js | Fixed the typo in both submitHandler() (line 220) and uploadHandler() (lines 227-228) methods to correctly reference pendingRequests |
| tests/tests/s3file.test.js | Updated test setup (line 58) and assertion (line 85) to use the corrected property name pendingRequests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Property name typo
pendingRquestsprevented the form submission handler from correctly waiting on pending upload requests.Changes
pendingRquests→pendingRequestsinsubmitHandler()anduploadHandler()methodsThe typo caused
Promise.all()to wait onundefinedinstead of the actual pending requests array, breaking the upload flow in Safari's custom element implementation.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.