Skip to content

Add test coverage for CSRF-disabled scenarios #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantcopley merged 2 commits into from
Dec 2, 2025
Merged

Add test coverage for CSRF-disabled scenarios #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f1c63f
Initial plan
Copilot Dec 2, 2025
4608c4b
Add test coverage for csrfEnabled = false scenarios
Copilot Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions test-harness/tests/specs/CBWIRESpec.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,52 @@ component extends="coldbox.system.testing.BaseTestCase" {
} ).toThrow( type="CBWIREException", message="Page expired." );
} );

it( "should process requests without CSRF verification when csrfEnabled = false", function() {
var settings = getInstance( "coldbox:modulesettings:cbwire" );
var originalSetting = settings.csrfEnabled;
settings.csrfEnabled = false;

var payload = incomingRequest(
memo = {
"name": "TestComponent",
"id": "Z1Ruz1tGMPXSfw7osBW2",
"children": []
},
data = {
"count": 1
},
calls = [
{
"path": "",
"method": "changeTitle",
"params": []
}
],
updates = {},
csrfToken = "badToken"
);

// Should not throw an error even with bad token when CSRF is disabled
var response = cbwireController.handleRequest( payload, event );
expect( isStruct( response ) ).toBeTrue();
expect( response.components[1].effects.html ).toInclude( "CBWIRE Slays!" );

// Restore original setting
settings.csrfEnabled = originalSetting;
} );

it( "should return empty string from generateCSRFToken() when csrfEnabled = false", function() {
var settings = getInstance( "coldbox:modulesettings:cbwire" );
var originalSetting = settings.csrfEnabled;
settings.csrfEnabled = false;

var token = cbwireController.generateCSRFToken();
expect( token ).toBe( "" );

// Restore original setting
settings.csrfEnabled = originalSetting;
} );

it( "should provide a handleRequest() method that returns subsequent payloads", function() {
var payload = incomingRequest(
memo = {
Expand Down