Skip to content

Use getApplicationMetadata() for cross-platform session detection in TokenService #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantcopley merged 5 commits into from
Dec 2, 2025
Merged

Use getApplicationMetadata() for cross-platform session detection in TokenService #251

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a377df
Initial plan
Copilot Dec 2, 2025
04e2170
Use cross-platform session detection with getApplicationMetadata()
Copilot Dec 2, 2025
f1b69f9
Cache app metadata and improve catch block comment
Copilot Dec 2, 2025
a62978b
Initialize appMetadata as struct and use structCount check
Copilot Dec 2, 2025
d297b39
Use structIsEmpty for better readability
Copilot Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion models/services/TokenService.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ component accessors="true" singleton {
*/
variables.csrfService = "";

/**
* Cache for application metadata to avoid repeated lookups
*/
variables.appMetadata = {};

/**
* Generates a CBWIRE-specific token that doesn't expire.
* Stored using the configured storage implementation and lasts for session lifetime.
Expand Down Expand Up @@ -71,7 +76,31 @@ component accessors="true" singleton {
private function generateNewToken() {
// Generate a cryptographically secure random token
var tokenBase = "#createUUID()##getRealIP()##randRange( 0, 65535, "SHA1PRNG" )##getTickCount()#";
return uCase( left( hash( tokenBase & session.sessionid, "SHA-256" ), 40 ) );

// Include session ID if sessions are enabled (cross-platform check)
var sessionId = "";
if ( isSessionManagementEnabled() ) {
try {
sessionId = session.sessionid;
} catch ( any e ) {
// Handle cases where session scope exists but sessionid property is not yet available,
// or when session operations fail during application startup
}
}

return uCase( left( hash( tokenBase & sessionId, "SHA-256" ), 40 ) );
}

/**
* Checks if session management is enabled in the application (cross-platform)
*
* @return True if session management is enabled, false otherwise
*/
private function isSessionManagementEnabled() {
if ( structIsEmpty( variables.appMetadata ) ) {
variables.appMetadata = getApplicationMetadata();
}
return structKeyExists( variables.appMetadata, "sessionManagement" ) && variables.appMetadata.sessionManagement;
}

private function getRealIP() {
Expand Down