Make punpy an optional dependency #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
So I see you merged this into a branch with the same name as mine. What does it mean? |
Contributor
|
Was about to send you a message. The workflow was not passing, and wasn't too sure how to make changes in your fork. So I first merged into a new separate branch on comet_maths, then made some minor edits (black linting, and tox.ini file) and then merged that into the main. |
Contributor
Author
|
OK thanks a lot:). I see the changes and the tests pass on our end (except the interpolation test of course). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes comet-toolkit/punpy#17 .