Skip to content

fix panic on non-yaml files #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taigrr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix panic on non-yaml files #206

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2edf1cc
fix panic on non-yaml
taigrr Nov 2, 2023
551a5e8
Merge branch 'master' into fix-nonyaml-panic
taigrr Nov 4, 2023
187b8db
Merge branch 'master' into fix-nonyaml-panic
taigrr Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pkg/app/test_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,7 @@ func execute(s suite.Suite, filters runtime.Filters) (runtime.Result, error) {
return result, nil
}

func getSuite(filePath string, fileName string) (suite.Suite, error) {
s := suite.Suite{}

func getSuite(filePath string, fileName string) (s suite.Suite, err error) {
content, err := readFile(filePath)
if err != nil {
return suite.Suite{}, err
Expand All @@ -190,9 +188,14 @@ func getSuite(filePath string, fileName string) (suite.Suite, error) {
return suite.Suite{}, err
}
}

defer func() {
if r := recover(); r != nil {
s = suite.Suite{}
err = fmt.Errorf("Error: %v", r)
}
}()
s = suite.NewSuite(content, overwriteContent, fileName)
return s, nil
return
}

func readFile(filePath string) ([]byte, error) {
Expand Down