Skip to content

Conversation

@YazdanRa
Copy link
Contributor

Description

Replacing pre-commit with prek and add support for prek in hooks

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run uv run poe all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run uv run poe doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running uv run poe doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Faster pre commit checks and hook installation

Steps to Test This Pull Request

N/A

Additional Context

#1797

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.95%. Comparing base (52d84c1) to head (9ad3b9d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1799   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          60       60           
  Lines        2646     2646           
=======================================
  Hits         2592     2592           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YazdanRa YazdanRa force-pushed the feat/support-prek branch 2 times, most recently from 08c781c to 83e3832 Compare January 14, 2026 05:31
@YazdanRa YazdanRa marked this pull request as ready for review January 14, 2026 05:39
@YazdanRa
Copy link
Contributor Author

I should maybe add the pre-commit in the test dependency group and parameterize the tests to check for both. wdyt?

@bearomorphism
Copy link
Collaborator

I should maybe add the pre-commit in the test dependency group and parameterize the tests to check for both. wdyt?

sure, why not

Copy link
Collaborator

@bearomorphism bearomorphism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits

@bearomorphism
Copy link
Collaborator

Thanks!

@bearomorphism
Copy link
Collaborator

This looks great! Let's wait for other maintainer's input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants