-
-
Notifications
You must be signed in to change notification settings - Fork 311
feat(prek): supporting prek as an alternative to pre-commit and switching to prek #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7430f5c to
1dfb345
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1799 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 60 60
Lines 2646 2646
=======================================
Hits 2592 2592
Misses 54 54 ☔ View full report in Codecov by Sentry. |
08c781c to
83e3832
Compare
|
I should maybe add the |
sure, why not |
bearomorphism
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits
|
Thanks! |
…as an alternative to 'pre-commit'
40a3c78 to
f004043
Compare
|
This looks great! Let's wait for other maintainer's input. |
Description
Replacing pre-commit with prek and add support for prek in hooks
Checklist
Code Changes
uv run poe alllocally to ensure this change passes linter check and testsDocumentation Changes
uv run poe doclocally to ensure the documentation pages renders correctlyExpected Behavior
Faster pre commit checks and hook installation
Steps to Test This Pull Request
N/A
Additional Context
#1797