-
Notifications
You must be signed in to change notification settings - Fork 804
P3371R5 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS #8550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
df99190 to
d933aae
Compare
|
Too late now, but this would have been much less difficult to review as two commits, one doing all the Edit: three commits, even. One changing inout to in, one adding/removing blocks of text, and then one changing every "class Scalar" to "scalar Scalar", which needs to be done after adding the new functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhoemmen please confirm that the new class Scalar template parameters being added by this paper should actually be scalar Scalar instead, since that's part of this paper, right?
Edit: yes, the editor's note at https://wiki.edg.com/pub/Wg21kona2025/StrawPolls/P3371R5.html#constrain-all-class-scalar-template-parameters says to rename all class Scalar to scalar Scalar after applying the changes from the paper. So the wording in the paper is "wrong" but the paper gives instructions for fixing it.
jwakely
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paper has these line breaks in template parameter lists but they're unnecessary IMHO.
Are we going to get conflicts when the LWG issues from Kona are applied? |
This comment was marked as outdated.
This comment was marked as outdated.
The itemdecl has the right order. See cplusplus#8550 (comment)
|
Everything should be ready to merge now.
I'm not sure. It looks like the paper makes the exact same changes as LWG4137, so in theory, they will just be identical during merging, which git shouldn't see as a conflict. |
…pdates consistent with the BLAS Fixes NB US 168-277 (C++26 CD).
5ff4c5a to
789ba10
Compare
Fixes #8479
Fixes NB US 168-277 (C++26 CD).
Also fixes cplusplus/papers#2028
Also fixes https://github.com/cplusplus/nbballot/issues/852