refactor: deprecate old schema #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreichirila0712
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
============================================
+ Coverage 93.89% 93.90% +0.01%
- Complexity 781 782 +1
============================================
Files 189 190 +1
Lines 2567 2570 +3
Branches 53 53
============================================
+ Hits 2410 2413 +3
Misses 132 132
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Member
|
@andreichirila0712 thank you for the contribution! Please update the There are also some resource files that need to be updated:
|
andrii-bodnar
approved these changes
Jan 20, 2025
Member
andrii-bodnar
left a comment
andrii-bodnar
left a comment
There was a problem hiding this comment.
@andreichirila0712 thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the schema class
PreTranslateEfficiencyGenerateReportRequest.javatoPreTranslateAccuracyGenerateReportRequest.java.Deprecated the old class to maintain backward compatibility.
The old class now extends the new one, so both functionalities (of old and new class) are available.
No functionality was changed, just updated the schema name.
Updated test in
com/crowdin/client/reports/ReportsApiTest.javato reflect the new schema and naming as requested in the feedback provided.Modified the following resources files:
resources/api/reports/preTranslateEfficiencyReportStatus.jsonresources/api/reports/generatePreTranslateEfficiencyReport.jsonThe changes were made to ensure consistency with the new schema and naming.
All tests passed successfully after the changes were made.