feat: Add support to Remove String Approvals endpoint #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2025 15:54
* Implemented DELETE method for removing string approvals. * Added test to validate the new endpoint's functionality.
* Updated removeStringApprovals implementation to improve handling of required parameters. * Updated deleteStringTranslations implementation to improve handling of optional parameters. * Added request mocking and a unit test for removeStringApprovals in StringTranslationsApiTest. * Adjusted the corresponding test for deleteStringTranslations to match the new implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
============================================
+ Coverage 94.13% 94.14% +0.01%
- Complexity 809 810 +1
============================================
Files 190 190
Lines 2725 2729 +4
Branches 54 54
============================================
+ Hits 2565 2569 +4
Misses 134 134
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
approved these changes
Jan 29, 2025
Member
andrii-bodnar
left a comment
andrii-bodnar
left a comment
There was a problem hiding this comment.
@andreichirila0712 thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces support for the `Remove String Approvals` endpoint and refactors `deleteStringTranslations` method and its corresponding test for better parameter handling.
Changes
Remove String Approvalsendpoint.removeStringApprovals) and the existing one (deleteStringTranslations) to fix request type and parameters requirements.HTTPmethod fromGETtoDELETEfor deletion operations.Optional.of()in case ofrequired parametersin order to match documentation.Testing
removeStringApprovalsTestand refactoreddeleteTranslationsTestto ensure correct functionality.request mock buildersfor theDELETEoperations to includequery parameters.Additional notes
Optional.of()is that on the documentation thestringIdparameter is marked asrequired, so it cannot benull.request mock buildersused another method fromRequestMock.java, the one that takes into account thequery params.