Skip to content

Conversation

@andreichirila0712
Copy link
Contributor

Summary

This introduces support for managing group managers and teams in the application.

Targets: issue#312

Changes

  • Added models for GroupManager and GroupTeam, including response handling models (GroupManagerResponseList, GroupTeamResponseList, ...).
  • Implemented endpoints to list, update, and retrieve group managers and teams.
  • Added unit tests to verify the functionality of new endpoints.
  • Included mock server data for API responses to ensure correctness.

Testing

  • Mock data was added to test the newly API use cases like listing, retrieving, and updating group teams and managers.
  • All tests passed successfully.

Additional notes

  • New classes (e.g. GroupTeam) were created because the new API methods had response structures that differed from existing ones. For instance, the List Group Teams response includes a unique identifier and a nested team object, which matches the structure of the List Teams API.
  • Existing models were reused in the newly models to avoid redundancy, but new classes were necessary to handle unique fields and correctly map the API responses as per the documentation.

* Introduced new endpoints to manage group managers and group teams (listing, updating, and retrieving).
* Added and integrated new models for seamless functionality.
* Added unit tests and mock API resources to ensure correct functionality.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (47b3128) to head (9a622b4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
+ Coverage     94.14%   94.20%   +0.07%     
- Complexity      810      818       +8     
============================================
  Files           190      192       +2     
  Lines          2729     2758      +29     
  Branches         54       54              
============================================
+ Hits           2569     2598      +29     
  Misses          134      134              
  Partials         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreichirila0712 thank you!

@andrii-bodnar andrii-bodnar linked an issue Feb 17, 2025 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit a20de55 into crowdin:master Feb 17, 2025
2 checks passed
@andreichirila0712 andreichirila0712 deleted the feature/312-add-support-for-group-managers-and-teams branch December 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for new group managers and teams features

3 participants