Skip to content

Conversation

@andrewshadura
Copy link

Hi,

This pull request extracts more strings into translatable resources and fixes punctuation in some source strings and corresponding translation.

While at it, it would be great if you uploaded these translations to Transifex, since it’s missing some of them (e.g. Russian).

Thanks!

@mvl22
Copy link
Member

mvl22 commented May 5, 2020

Nice, thanks!

@andrewshadura
Copy link
Author

Speaking of which, the Russian translation needs an overhaul since it reads quite unnatural. I will submit updates as soon as it is on Transifex since it’s a bit inconvenient to do that across multiple XML files.

@oliverlockwood oliverlockwood self-requested a review May 5, 2020 16:28
@oliverlockwood
Copy link
Member

Hi @andrewshadura - thanks for submitting this. We'll get to reviewing this in due course when we've dealt with some other issues.

Of the languages CycleStreets is currently translated to, only
French has a convention of putting a space before an exclamation
mark or a colon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants