Typing & Refactoring #205
Open
Typing & Refactoring #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Fulford <dfulford@eivcapital.com>
Signed-off-by: David Fulford <dfulford@eivcapital.com>
Signed-off-by: David Fulford <dfulford@eivcapital.com>
Signed-off-by: David Fulford <dfulford@eivcapital.com>
Signed-off-by: David Fulford <dfulford@eivcapital.com>
Signed-off-by: David Fulford <dfulford@eivcapital.com>
for more information, see https://pre-commit.ci
Signed-off-by: David Fulford <dfulford@eivcapital.com>
for more information, see https://pre-commit.ci
Signed-off-by: David Fulford <dfulford@eivcapital.com>
for more information, see https://pre-commit.ci
Signed-off-by: David Fulford <dfulford@eivcapital.com>
for more information, see https://pre-commit.ci
Signed-off-by: David Fulford <dfulford@eivcapital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now fully typed. This is especially helpful with the param
dicts which were being passed askwargstomatplotlib, but were also being modified withindaftprior to being passed on.In addition, I've refactored the
PGM,Node,Edge, andPlateinto separate files, and resolved circular dependencies resulting from exports. Some of the names from the recent refactor were changed to conform to more common Python style.Lastly, one of the tests was in error, testing
wordy.pngtwice. I've fixed this.