acc: Add EnvMatrixExclude config option #4178
Merged
+128
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| Env.PYTHONUNBUFFERED = "1" | ||
| Env.PYTHONUTF8 = "1" | ||
|
|
||
| EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["terraform", "direct"] |
Contributor
There was a problem hiding this comment.
Should we combine these to completely enumerate all environments the test would run in? Something like:
EnvMatrix = [
{"DATABRICKS_BUNDLE_ENGINE":"terraform", "READPLAN":0},
{"DATABRICKS_BUNDLE_ENGINE":"direct", "READPLAN":0},
{"DATABRICKS_BUNDLE_ENGINE":"direct", "READPLAN":1},
]Much easier reason about.
Contributor
Author
There was a problem hiding this comment.
No, this does not allow composition. For example, we set today DATABRICKS_BUNDLE_ENGINE variants for all tests but READPLAN for some subset, they don't know about each other can be configured separately.
shreyas-goenka
approved these changes
Dec 29, 2025
Collaborator
|
Commit: f798ebb
20 interesting tests: 14 KNOWN, 4 RECOVERED, 1 SKIP, 1 flaky
Top 29 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 21129d6
37 interesting tests: 14 KNOWN, 14 FAIL, 4 flaky, 4 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In #4134 I added special case for engine/readplan vars directly into acceptance_test.go. This generalizes that, making this feature available to other env var combinations.