Add fallback default_catalog property for pydabs template
#4184
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pydabs template was missing the hive_metastore fallback for the default_catalog property. This caused inconsistent behavior with default-python for non-UC workspaces. The hive_metastore value serves as a sentinel that allows pipeline templates to detect non-UC configurations and comment out the catalog field (which would otherwise be rejected by the DLT API).
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Dec 31, 2025
Collaborator
|
Commit: bdcd22e
19 interesting tests: 18 KNOWN, 1 SKIP
Top 22 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds the
hive_metastorefallback for thedefault_catalogproperty of thepydabstemplate.Why
I asked Claude Code about any template inconsistencies and this is what it cae up with.
More contetxg: this fallback value serves as a sentinel that allows pipeline templates to detect non-UC workspace configurations. When
default_catalogresolves tohive_metastore, the pipeline templates comment out the catalog field (which would otherwise be rejected by the DLT API, since it doesn't accept 'hive_metastore' as a catalog name).See the same logic in default-python here:
https://github.com/databricks/cli/blob/main/libs/template/templates/default-python/databricks_template_schema.json#L51
Testing
make test-update-templatesto regenerate acceptance testsmake fmtandmake lintpass