Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen/_openapi_sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b5283a925ecf8929263b63f41b182246745d81a0
44cbc832f1b070c47544ff470fd8498853d24cf3
3 changes: 2 additions & 1 deletion NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@
* Add `accessModes` and `storageLocation` fields for `com.databricks.sdk.service.sharing.Table`.
* Add `command` and `envVars` fields for `com.databricks.sdk.service.apps.AppDeployment`.
* Add `fullName` and `securableType` fields for `com.databricks.sdk.service.catalog.AccessRequestDestinations`.
* [Breaking] Change `deleteKafkaConfig()` method for `workspaceClient.featureEngineering()` service . Method path has changed.
* [Breaking] Change `deleteKafkaConfig()` method for `workspaceClient.featureEngineering()` service . Method path has changed.
* [Breaking] Change long-running operation configuration for `workspaceClient.postgres().deleteRole()` method . Long running operation response type changed to `Void class`.
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,26 @@ public DeleteRoleOperation(PostgresService impl, Operation operation) {
}

/**
* Wait for the operation to complete and return the resulting Role. Waits indefinitely if no
* timeout is specified.
* Wait for the operation to complete and return the resulting . Waits indefinitely if no timeout
* is specified.
*
* @return the created Role
* @return the created
* @throws TimeoutException if the operation doesn't complete within the timeout
* @throws DatabricksException if the operation fails
*/
public Role waitForCompletion() throws TimeoutException {
return waitForCompletion(Optional.empty());
public void waitForCompletion() throws TimeoutException {
waitForCompletion(Optional.empty());
}

/**
* Wait for the operation to complete and return the resulting Role.
* Wait for the operation to complete and return the resulting .
*
* @param options the options for configuring the wait behavior, can be empty for defaults
* @return the created Role
* @return the created
* @throws TimeoutException if the operation doesn't complete within the timeout
* @throws DatabricksException if the operation fails
*/
public Role waitForCompletion(Optional<LroOptions> options) throws TimeoutException {
public void waitForCompletion(Optional<LroOptions> options) throws TimeoutException {
Optional<Duration> timeout = options.flatMap(LroOptions::getTimeout);
long deadline =
timeout.isPresent()
Expand Down Expand Up @@ -88,9 +88,9 @@ public Role waitForCompletion(Optional<LroOptions> options) throws TimeoutExcept

try {
JsonNode responseJson = objectMapper.valueToTree(operation.getResponse());
return objectMapper.treeToValue(responseJson, Role.class);
objectMapper.treeToValue(responseJson, Void.class);
} catch (JsonProcessingException e) {
throw new DatabricksException("Failed to unmarshal role response: " + e.getMessage(), e);
throw new DatabricksException("Failed to unmarshal response: " + e.getMessage(), e);
}
}

Expand Down
Loading