Skip to content

Conversation

@sibyabin
Copy link
Contributor

Add changes to

  • fix the incremental table getting recreated when the defaultProject is not available as part of the workflow_settings.yaml
  • Minimal unit test for the same

@sibyabin sibyabin requested a review from a team as a code owner December 23, 2025 08:02
@sibyabin sibyabin requested review from fafsdafsafs and removed request for a team December 23, 2025 08:02
@google-cla
Copy link

google-cla bot commented Dec 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sibyabin
Copy link
Contributor Author

Hi @fafsdafsafs / @kolina Could you please review/check this PR when you get a chance ?

@kolina
Copy link
Contributor

kolina commented Dec 29, 2025

Hi! Sorry for the late response, currently our integration tests are broken for not related reasons. After we fixed them, I'll review this PR.

Copy link
Contributor

@kolina kolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase the PR to the latest main after I fixed integration tests in ee5b5d1.

I want to re-run them after my fix in your PR

@sibyabin sibyabin force-pushed the fix/issue-2053-avoid-incremental-table-recreation branch from acb9e7d to 8a6f201 Compare January 6, 2026 07:44
@kolina
Copy link
Contributor

kolina commented Jan 7, 2026

/gcbrun

@kolina kolina merged commit 18a3f7c into dataform-co:main Jan 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants