added broadcast join operator #229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-bordegaray
force-pushed
the
gene.bordegaray/2025/11/add_broadcast_join_operator
branch
from
2b0f8ad to
1a31b0d
Compare
gene-bordegaray
force-pushed
the
gene.bordegaray/2025/11/add_broadcast_join_operator
branch
from
b2292dd to
718808b
Compare
Author
|
In CI, test tpcd queries 10, 35, and 69 seemed to fail but pass repetitively locally. Are these known as flaky tests in CI? |
gene-bordegaray
commented
Dec 23, 2025
| if !partition_group.contains(&i) { | ||
| style = "[style=invis]"; | ||
| } | ||
| } else if let Some(partition_group) = &isolator_partition_group |
Author
There was a problem hiding this comment.
clippy wouldn't leave me alone 😄
gene-bordegaray
commented
Dec 23, 2025
| if let Some(stage) = plan.input_stage() { | ||
| result.push(stage); | ||
| } | ||
| if let Some(plan) = plan.as_network_boundary() |
Collaborator
They are flaky yes #267, although I the failures I see in this PR look different. I think the issue is that sometimes the queries in those tests get distributed and sometimes not, as the number of files produced by the tpc-ds generator is random |
Collaborator
|
With the current setup, almost no tpc-ds query is actually getting distributed. I actually needed to rework those tests in #264. It looks like at random points they do get distributed though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for broadcast join
Closes #223
Benches are volatile, doesn't seem like drastic improvements due to tpch data
Follow up could be some more benching