-
Notifications
You must be signed in to change notification settings - Fork 103
pre-request and post-response interceptors are added #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f199d2b
80b32c0
23d0b97
d837c1e
7602c35
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,45 @@ | ||||||||||||||||
| /** | ||||||||||||||||
| * Copyright 2018 Google Inc. All Rights Reserved. | ||||||||||||||||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||||
| * you may not use this file except in compliance with the License. | ||||||||||||||||
| * You may obtain a copy of the License at | ||||||||||||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||||||||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||||
| * See the License for the specific language governing permissions and | ||||||||||||||||
| * limitations under the License. | ||||||||||||||||
| */ | ||||||||||||||||
|
|
||||||||||||||||
| function Interceptor() { | ||||||||||||||||
|
|
||||||||||||||||
| /** | ||||||||||||||||
| * @type {Array<{done: Function, error: Function }>} | ||||||||||||||||
| */ | ||||||||||||||||
| this.handlers = []; | ||||||||||||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't need a pretty name, it could be |
||||||||||||||||
|
|
||||||||||||||||
| /** | ||||||||||||||||
| * Register an interceptor | ||||||||||||||||
| * @param {Function} done | ||||||||||||||||
| * @param {Function} [error] | ||||||||||||||||
| * @returns {number} The interceptor Id to be used for ejection | ||||||||||||||||
| */ | ||||||||||||||||
| this.use = function(done, error) { | ||||||||||||||||
| this.handlers.push({ | ||||||||||||||||
| done, | ||||||||||||||||
| error: error || (() => {}) | ||||||||||||||||
| }); | ||||||||||||||||
|
|
||||||||||||||||
| return this.handlers.length - 1; | ||||||||||||||||
|
Comment on lines
+28
to
+33
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. push() returns the array's new length:
Suggested change
Also this.use = function() {
return this.handlers.push(arguments) - 1;
} |
||||||||||||||||
| }; | ||||||||||||||||
|
|
||||||||||||||||
| /** | ||||||||||||||||
| * @param {number} id - A registered interceptor Id | ||||||||||||||||
| */ | ||||||||||||||||
| this.eject = function (id) { | ||||||||||||||||
| if (this.handlers[id]) | ||||||||||||||||
| this.handlers[id] = null; | ||||||||||||||||
|
Comment on lines
+40
to
+41
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No harm in re-assigning a null value to null again:
Suggested change
|
||||||||||||||||
| }; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| export default Interceptor; | ||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an imported class here adds a bunch of module and setup overhead and makes it so the registry of interceptors can't be a simple local variable.