Fix THSJIT_TensorType_sizes signature #1512
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the other functions with an allocator use size_t. In addition, the `sz` variable in the implementation is `size_t`, and the p/invoke method in `LibTorchSharp.THSJIT.cs` uses the same delegate as the others.
ds5678
force-pushed
the
fix-jit-tensortype-sizes-signature
branch
from
0cd9037 to
0c8e276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other functions with an allocator use size_t. In addition, the
szvariable in the implementation issize_t, and the p/invoke method inLibTorchSharp.THSJIT.csuses the same delegate as the others.