Fix read-only read-write handler
#142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asamuzaK
changed the title
read-only read-writeread-only read-write handler
Contributor
Author
|
Not sure where to add this, but here's a test in wpt format. <!DOCTYPE html>
<title>3816</title>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<!-- Regression test for https://github.com/jsdom/jsdom/issues/3816 -->
<input id="input0" />
<input id="input1" readonly="" />
<input id="input2" readonly="readonly" />
<script>
"use strict";
const input0 = document.getElementById('input0');
const input1 = document.getElementById('input1');
const input2 = document.getElementById('input2');
test(() => {
assert_false(input0.matches(':read-only'));
assert_true(input0.matches(':read-write'));
}, 'no readonly attr');
test(() => {
assert_true(input1.matches(':read-only'));
assert_false(input1.matches(':read-write'));
}, 'readonly attr with empty string');
test(() => {
assert_true(input2.matches(':read-only'));
assert_false(input2.matches(':read-write'));
}, 'readonly attr with value');
</script> |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix jsdom/jsdom#3816