oils-for-unix: Update broken platforms #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @jperkin does not like using BROKEN because it hides error output in bulk build reports. |
Adding BUILDLINK_TRANSFORM did not solve the issue: oils-for-unix/oils#1942 So this check doesn't do anything.
MarcCoquand
force-pushed
the
add-broken-platforms
branch
from
180cb19 to
aeb2c32
Compare
Author
|
Makes sense.
I updated the PR then to just remove the unnecessary check.
…On Mon Jun 23, 2025 at 11:23 PM BST, nia wrote:
alarixnia left a comment (drecklypkg/dreckly#145)
I think @jperkin does not like using BROKEN because it hides error output in bulk build reports.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a useless check and also add a note on broken platforms.