-
Notifications
You must be signed in to change notification settings - Fork 1
Implement Validation Phase Ruleset #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
We will leave the unimplemented rules to be covered by a future PR. |
douglowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good - there's a couple of changes I've noted in comments.
I also think we should be including tests for startTime and endTime - as mentioned in the main text of the 'Review Process' section. We perhaps can add these later though.
rocrate_validator/profiles/five-safes-crate/must/13_validation_phase.ttl
Outdated
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/should/13_validation_phase.ttl
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/should/13_validation_phase.ttl
Outdated
Show resolved
Hide resolved
…actionStatus into two: a SHOULD (for existance) and a MUST (for proper values)
This PR addresses #44.
Rulses Implemented
additionalTypeof the ValidationCheck entity MUST be set to https://w3id.org/shp#ValidationCheck (i)RootDataEntity-->mentionsSHOULD referenceValidationCheckValidationCheckMUST be of typeAssessActionValidationCheckMUST provide a human-readable summary of the review and result (ii)ValidationCheck-->objectSHOULD point to the root of the RO-CrateValidationCheck-->instrumentSHOULD reference an object with @id https://w3id.org/5s-crate/0.4ValidationCheckSHOULD haveactionStatuspropertyValidationCheck-->actionStatusMUST have one of the allowed values(i) This is not an actual rule, but rather a definition of what constitutes a ValidationCheck entity. As such it was not implemented given its axiomatic nature.
(ii) This rule is implicitly included in rule 3, hence it was not implemented.
(iii) This cannot be entirely done without a manual check. Here we only check that the name property of
ValidationCheckis a string of at least 10 characters.Rules Not Implemented (need clarifications)
ValidationCheck-->objectMAY point to additional entities, as required by TREs/workflows, as an array of objects.ValidationCheck-->instrumentMAY reference additional expected input parameters, as required by TREs/workflows, as an array of instrumentsValidationCheck-->objectMAY reference additional checks of provided input parameters against expected, as required by TREs/workflows, as an array of objects