Fix add forms for affordances #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
TejInaco
force-pushed
the
fix-add-forms-for-affordances
branch
from
c284f30 to
7e1a150
Compare
egekorkan
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
Fix the functionality of adding forms for every type of property, even when the form uploaded by the user has an undefined value. This means there is no operation value associated with a given href value.
Previously, the application crashed when there was a form with an href value and no operation associated.
Users can add a form that must have both an operation value and an href value.
If the user adds a form with an operation already used for the same href value, it will raise a duplication error.
Closes #168