Skip to content

Generalize mat vec #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
csparker247 wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Generalize mat vec #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca54f71
Generalize MatVec multiplication types
csparker247 Dec 9, 2024
3a85308
string: Add ref
csparker247 Dec 9, 2024
7a52675
Restore mat/vec
csparker247 Dec 9, 2024
139481f
Remove trailing semicolon
csparker247 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/educelab/core/types/Mat.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Mat
static constexpr std::size_t cols{Cols};

/** Default constructor */
Mat() { vals_.fill(0); };
Mat() { vals_.fill(0); }

/** @brief Constructor with fill values */
template <typename... Args>
Expand Down
2 changes: 1 addition & 1 deletion include/educelab/core/utils/String.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ static auto split(std::string_view s, const Ds&... ds)
// Split string
std::vector<std::string_view> tokens;
std::string_view::size_type begin{0};
for (const auto [end, size] : delimPos) {
for (const auto& [end, size] : delimPos) {
// ignore nested delimiters
if (end < begin) {
continue;
Expand Down