Skip to content

Conversation

@GiedriusS
Copy link
Contributor

Error can contain stuff like %s and then that gets interpreted as a format string command. That's really not the intention here.

Error can contain stuff like %s and then that gets interpreted as a
format string command. That's really not the intention here.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Copy link
Collaborator

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Btw the CI fails due to actions/ versions...could you bump that as well? 🙂

would need it for setup-go checkout too

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
@GiedriusS GiedriusS force-pushed the testutil_rm_formatting branch from 8856a81 to 36c8090 Compare May 9, 2025 09:31
@GiedriusS
Copy link
Contributor Author

I'm not trusted on this repo, so GitHub is probably continuing to run the version from main instead of this branch,

@saswatamcode
Copy link
Collaborator

Ack I think this PR is fine to merge, can address the actions versions in next PR.

@saswatamcode saswatamcode merged commit dd7660e into efficientgo:main May 9, 2025
1 of 9 checks passed
@GiedriusS GiedriusS deleted the testutil_rm_formatting branch May 9, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants