Add docker-slim support #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
reviewed
Apr 13, 2023
Contributor
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! This is great. I only wonder if it's time to rethink how we can add multiple providers in efficient way going forward.
For example I would argue slim version could be another "*Environment". The API was designed to accommodate such thing in future e.g. KindEnvironment or UnixProcessEnvironment and so on. This also mean it's maybe time for another packages that could extend this logic.
NOTE: We can break API on the way, given this is v0.14.0 version - actually that's why version we have v0.x version. Wanna brainstorm with me how it could look like?
Alternative is to perhaps have single option to Runnable "IsSlim" 🙃 but something future proof would be nice... WDYT?
And sorry for slow response, this is super quality code, I love it, thanks! - I am available to chat on Slack,Twitter,Linkedin etc (https://www.bwplotka.dev/)
Contributor
Author
|
Hi @bwplotka, I really like to discusse how we can do it future proof, I ping you on Slack. |
* Detect WSL2 and open in browser from Windows Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix hostAddr in WSL2 Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix host-local endpoint test in WSL2 Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fail fast to start in WSL2 with cadvisor Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Inline some conditionals Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Detect WSL 2 without relying on OS binaries/tools Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix var name Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Drop environment.WSL2() and use func from package Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Improve how OS platform is checked Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Document what is WSL Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix WSL2 check for network test Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix networkType deletion Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Separate OS platform function into its own package * Reorder imports * Add TODO to new `host` package * Please the copyright linter Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
* Use minio console access as readiness check Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Update etcd example lines Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Please the copyright linter * Test minio readiness by making a bucket * Rebuild Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Adding comment linking to issue about minio readiness check * Go fmt file * Update example go.sum file * Update mdox entry Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
* Improve minio readiness check It uses now the cluster health endpoint, so we don't need the console anymore. Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Make xargs macOS friendly Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Remove now unused console port name variable Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Update README Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
* Add option to enable TLS for minio Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix readiness probe Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix lint Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
* env_docker: support docker-in-docker If we are running e2e tests inside Docker then it's not so straightforward to access host's network. Let's use the special `host.docker.internal` for that. * env_docker: try resolve before using docker gateway
* CI: ensure macOS can connect to containers in Lima This commit allows the macOS host in CI to route packets directly to the IP addresses of containers running inside the Lima guest VM, without needing to explicitly forward ports via SSH. This allows macs to behave the same way that Linux hosts do. Signed-off-by: Lucas Servén Marín <lserven@gmail.com> * e2e: add environment for kind This commit adds a new implementation of the Environment interface implemented using kind, ie Kubernetes in Docker. The motivation is that you might want to manually run some complex configurations in the e2e tests using Kubernetes resources and still manage the tests simply using the e2e package. Users who need the escape hatch of deploying things to a Kubernetes cluster manually, e.g. workloads that are not a simple deployment, can use the kubeconfig file located in the environment's shared directory. Signed-off-by: Lucas Servén Marín <lserven@gmail.com> --------- Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Contributor
|
Can't see any ping, let's retry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type dockerSlimRunnable to be able to run conatiners and build slim images with docker-slim. Some of the differences compared to dockerRunnable:
docker-slim buildcommand.I tested the code with docker-slim and the it runs well and build the slim image after tests are finished but the container logs only available after the docker-slim stopped it.