[Do not merge] Convert tabs that can be applies-switch #4429
+379
−521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vale Linting ResultsSummary: 2 warnings, 23 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.BritishSpellings | Use American English spelling 'toward' instead of British English 'towards'. |
💡 Suggestions (23)
| File | Line | Rule | Message |
|---|---|---|---|
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 425 | Elastic.Acronyms | 'PEM' has no definition. |
| deploy-manage/users-roles/cluster-or-deployment-auth/saml.md | 540 | Elastic.Acronyms | 'SAML' has no definition. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 21 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-capacity-data-node.md | 57 | Elastic.FutureTense | 'will need' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-cluster-shard-limit.md | 81 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-shard-limit.md | 82 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 27 | Elastic.FutureTense | 'will increase' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/increase-tier-capacity.md | 139 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/repeated-snapshot-failures.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 27 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/restore-from-snapshot.md | 231 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 29 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.Wordiness | Consider using 'to' instead of 'In order to'. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will resolve' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/elasticsearch/troubleshoot-migrate-to-tiers.md | 116 | Elastic.FutureTense | 'will also' might be in future tense. Write in the present tense to describe the state of the product as it is now. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 20 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/apm/apm-server-response-codes.md | 24 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI. |
| troubleshoot/observability/troubleshoot-logs.md | 49 | Elastic.WordChoice | Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI. |
Contributor
Author
|
Edit: found ittttt |
…-leborgne/docs-content into convert-tabs-into-applies-switch
Contributor
Contributor
|
@florent-leborgne , what kind of reviews do you want on this? It's not the typical PR so I'm just thinking about how best to go about it 🕵️ |
2 tasks
Collaborator
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
most of this looks good, but please skip the elasticsearch troubleshooting content. I'll need to fix it with the page-level issues
| :::::: | ||
|
|
||
| ::::::{tab-item} Self-managed | ||
| ::::::{applies-item} self: |
Collaborator
There was a problem hiding this comment.
I think this is a case where self-managed is used as shorthand for ece eck self ... I can't be sure about this because I don't know how ECE handles this. maybe we need an issue to double-check this
Contributor
Author
There was a problem hiding this comment.
Yes I saw a few like this - it will still say the same "Self-managed", but in a badge so I don't think this is blocking, but should definitely be checked. Is that with your team? I remember Marci working on time series, maybe she'd know for this one?
Collaborator
|
as a side note, there's only maybe a handful of things in here with a range ... this could be split and most of it could be merged ASAP |
…abs-into-applies-switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts tabs that should now be applies-switch thanks to the recent and upcoming updates to the metadata system.
This PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure